Skip to content

[elasticsearch] fix elasticsearch.server.tags mapping - #6289

Merged
klacabane merged 6 commits into
elastic:mainfrom
klacabane:6167-server-tags-mapping
May 25, 2023
Merged

[elasticsearch] fix elasticsearch.server.tags mapping#6289
klacabane merged 6 commits into
elastic:mainfrom
klacabane:6167-server-tags-mapping

Conversation

@klacabane

@klacabane klacabane commented May 22, 2023

Copy link
Copy Markdown
Contributor

Closes #6167

elasticsearch.server.tags is mapped as nested but tags are array of string. This causes insertion failures on log entries that contain tags.

Testing

  • start stack elastic-package stack up -v -d --version 8.8.0-SNAPSHOT
  • start elasticsearch service that generate logs cd packages/elasticsearch && elastic-package service up -v
  • collect server logs at /tmp/service_logs/*_server.json
  • server logs with tags are ingested
  • no ingestion failure in logs anymore object mapping for [elasticsearch.server.tags] tried to parse field [null] as object, but found a concrete value\"}, dropping event!"
@klacabane klacabane added Integration:elasticsearch Elasticsearch Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels May 22, 2023
@klacabane klacabane self-assigned this May 22, 2023
@klacabane
klacabane marked this pull request as ready for review May 22, 2023 16:48
@klacabane
klacabane requested a review from a team as a code owner May 22, 2023 16:48
@elasticmachine

elasticmachine commented May 22, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-23T16:51:07.585+0000

  • Duration: 31 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 0
Total 60

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 22, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 87.5% (98/112) 👍
Lines 91.98% (562/611) 👍
Conditionals 100.0% (0/0) 💚
@klacabane
klacabane merged commit 2740852 into elastic:main May 25, 2023
@elasticmachine

Copy link
Copy Markdown

Package elasticsearch - 1.7.4 containing this change is available at https://epr.elastic.co/search?package=elasticsearch

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* fix mapping

* changelog

* remove unrelated change

* remove unrelated change

* bump patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:elasticsearch Elasticsearch Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services

3 participants