[Arista NG Firewall] Initial Release by MakoWish · Pull Request #6347 · elastic/integrations

MakoWish · 2023-05-26T17:46:38Z

Type of Change

Enhancement

What does this PR do?

This is an initial integration release for Arista NG Firewall (previously Untangle NG Firewall)

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Package has been tested with sample data from all covered event types

Related issues

Closes [Arista NG Firewall] Initial Release #6346

Additional Notes

I am not sure how to open elastic-package's stack up to accept live syslog data, so I am unable to create dashboards just yet. Once this initial release is available to install in my environment, I can get some dashboards created.

elasticmachine · 2023-05-26T17:49:58Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-06-22T21:50:17.513+0000
Duration: 14 min 29 sec

Test stats 🧪

Test	Results
Failed	0
Passed	15
Skipped	0
Total	15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2023-05-29T09:32:22Z

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6

Nice. A few comments.

efd6 · 2023-06-05T03:22:54Z

/test

efd6 · 2023-06-13T22:04:22Z

/test

efd6 · 2023-06-13T22:16:49Z

You will need to add a line to https://github.com/elastic/integrations/blob/main/.github/CODEOWNERS

/packages/arista_ngfw @elastic/security-external-integrations

(list is — should be — ordered alphabetically)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

MakoWish · 2023-06-13T22:27:16Z

You will need to add a line to https://github.com/elastic/integrations/blob/main/.github/CODEOWNERS
/packages/arista_ngfw @elastic/security-external-integrations
(list is — should be — ordered alphabetically)

Beat you to it, but did not do alphabetically, because I noticed it was not already. I will move my addition into order.

efd6 · 2023-06-13T23:21:22Z

/test

elasticmachine · 2023-06-13T23:37:11Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`1/1`)	💚
Files	100.0% (`7/7`)	💚
Classes	100.0% (`7/7`)	💚
Methods	100.0% (`36/36`)	💚
Lines	94.639% (`865/914`)	👍 8.103
Conditionals	100.0% (`0/0`)	💚

efd6

LGTM after cisco file is removed.

MakoWish · 2023-06-14T14:14:49Z

LGTM after cisco file is removed.

I reverted the changes, but how do I remove it?

…grations into arista_ng_firewall

MakoWish · 2023-06-14T17:57:16Z

I might just be making it worse, hahaha! I just did:

git checkout origin/main packages/cisco_secure_endpoint/data_stream/event/fields/ecs.yml

and committed. Would appreciate a tip on how to remove it.

Would it be better to just copy all my files into a new branch without the CSE file, delete this PR, and open a new PR with a single clean commit?

efd6 · 2023-06-14T23:02:53Z

Done. I just did a revert of the changes on that file an pushed it (you could copy from the main branch's state, but I did a file revert on that file for each of the commits here that touched it).

efd6 · 2023-06-14T23:03:02Z

/test

elasticmachine · 2023-06-14T23:03:49Z

💔 Build Failed

Buildkite Build
Commit: 7ca0fdf

Failed CI Steps

:pipeline:⬆️ Upload Pipeline: .buildkite/pipeline.yml

History

💔 Build #71 failed cd08f60
💔 Build #67 failed 03f05ec

MakoWish · 2023-06-19T17:44:13Z

@efd6,

Is there a way to install this onto a live Elastic cluster instead of just the elastic-package stack?

efd6

LGTM after minor issues addressed.

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

MakoWish · 2023-06-21T17:41:12Z

Anything else needed on this one? Also, is there a way to install onto a test cluster so I can push some live data to it? Or do I need to wait until the Beta is actually released?

efd6 · 2023-06-21T23:14:15Z

Easiest to wait until it's released.

efd6

Thanks

efd6 · 2023-06-21T23:16:23Z

/test

…grations into arista_ng_firewall

MakoWish · 2023-06-22T14:21:12Z

It failed because the expected results did not match after the ECS version change. Regenerated the expected results, and the test passes locally now. Please test again.

efd6 · 2023-06-22T21:50:05Z

/test

MakoWish · 2023-06-26T15:53:47Z

I'm getting a 404 when trying to view the BuildKite results again. It worked for a few days, but not anymore.

Anything else needed on this?

efd6 · 2023-06-28T00:35:39Z

Don't worry about the buildkite builds, they are not required at this stage.

efd6

Still LGTM

efd6 · 2023-06-28T00:37:07Z

Thanks

elasticmachine · 2023-06-28T00:58:56Z

Package arista_ngfw - 0.0.1 containing this change is available at https://epr.elastic.co/search?package=arista_ngfw

Initial release of Arista NG Firewall integration

a793126

jamiehynds added the Team:Security-External Integrations label May 29, 2023

jamiehynds added the New Integration Issue or pull request for creating a new integration package. label May 29, 2023

efd6 reviewed Jun 5, 2023

View reviewed changes

MakoWish requested a review from a team as a code owner June 5, 2023 16:24

efd6 reviewed Jun 5, 2023

View reviewed changes

Fix quotations on drop processor

8b16fff

efd6 reviewed Jun 13, 2023

View reviewed changes

MakoWish added 2 commits June 13, 2023 09:41

Apply changes after code review

178bf3f

Apply changes after code review, and fix conflicts.

03f05ec

MakoWish and others added 2 commits June 13, 2023 16:24

Add arista_ngfw owner to .github/CODEOWNERS

c23bd7e

Apply suggested owner change to manifest.yml

d772b0b

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Move previous addition to alphabetical order

cd08f60

efd6 reviewed Jun 14, 2023

View reviewed changes

MakoWish added 4 commits June 14, 2023 11:15

Attempt to remove cisco_secure_endpoint file

7e02277

Merge branch 'arista_ng_firewall' of https://github.com/MakoWish/inte…

22c2126

…grations into arista_ng_firewall

Attempt to remove cisco_secure_endpoint file

205b919

Merge branch 'arista_ng_firewall' of https://github.com/MakoWish/inte…

bf6c497

…grations into arista_ng_firewall

revert changes to cisco_secure_endpoint file

7ca0fdf

efd6 reviewed Jun 19, 2023

View reviewed changes

MakoWish and others added 9 commits June 19, 2023 16:56

Commit suggested change from code review

3d1aed3

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Commit suggested change from code review

cde3dd0

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Commit suggested change from code review

a11cabe

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Commit suggested change from code review

9ba34e3

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Commit suggested change from code review

08b367e

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Commit suggested change from code review

cab5250

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Commit suggested change from code review

468a234

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Commit suggested change from code review

11abda4

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Commit suggested change from code review

2fb9ae9

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

efd6 approved these changes Jun 21, 2023

View reviewed changes

MakoWish added 2 commits June 22, 2023 08:20

Regenerated expected results

9e78dd2

Merge branch 'arista_ng_firewall' of https://github.com/MakoWish/inte…

0c177d8

…grations into arista_ng_firewall

efd6 approved these changes Jun 28, 2023

View reviewed changes

efd6 merged commit e1c65f6 into elastic:main Jun 28, 2023

MakoWish deleted the arista_ng_firewall branch June 28, 2023 14:33

andrewkroh added the Integration:arista_ngfw Arista NG Firewall (Community supported) label Jul 22, 2024

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026

[Arista NG Firewall] Initial Release (elastic#6347)

d28bd79

Uh oh!

Conversation

MakoWish commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

What does this PR do?

Checklist

Author's Checklist

Related issues

Additional Notes

elasticmachine commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

elasticmachine commented May 29, 2023

efd6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

efd6 commented Jun 5, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

efd6 commented Jun 13, 2023

efd6 commented Jun 13, 2023

MakoWish commented Jun 13, 2023

efd6 commented Jun 13, 2023

elasticmachine commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

efd6 left a comment

Choose a reason for hiding this comment

MakoWish commented Jun 14, 2023

MakoWish commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

efd6 commented Jun 14, 2023

efd6 commented Jun 14, 2023

elasticmachine commented Jun 14, 2023

💔 Build Failed

Failed CI Steps

History

MakoWish commented Jun 19, 2023

efd6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MakoWish commented Jun 21, 2023

MakoWish commented May 26, 2023 •

edited

Loading

elasticmachine commented May 26, 2023 •

edited

Loading

elasticmachine commented Jun 13, 2023 •

edited

Loading

MakoWish commented Jun 14, 2023 •

edited

Loading