Skip to content

panw: allow usernames to contain spaces - #6463

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:6172-panw
Jun 7, 2023
Merged

panw: allow usernames to contain spaces#6463
efd6 merged 1 commit into
elastic:mainfrom
efd6:6172-panw

Conversation

@efd6

@efd6 efd6 commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Relaxes the constraint on usernames to allow spaces. This exists in the wild, so we should handle it.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels Jun 5, 2023
@efd6 efd6 self-assigned this Jun 5, 2023
@efd6
efd6 force-pushed the 6172-panw branch 4 times, most recently from b16d44b to 586db47 Compare June 5, 2023 09:20
@elasticmachine

elasticmachine commented Jun 5, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-05T12:53:46.994+0000

  • Duration: 19 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 52
Skipped 0
Total 52

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jun 5, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (15/15) 💚
Classes 100.0% (15/15) 💚
Methods 98.592% (70/71) 👍 2.365
Lines 94.345% (3270/3466) 👍 4.456
Conditionals 100.0% (0/0) 💚
@efd6
panw: allow usernames to contain spaces
4635063 
This exists in the wild, so we should handle it.
@efd6
efd6 marked this pull request as ready for review June 5, 2023 12:53
@efd6
efd6 requested a review from a team as a code owner June 5, 2023 12:53
@elasticmachine

elasticmachine commented Jun 5, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kcreddy
kcreddy approved these changes Jun 7, 2023
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6
efd6 merged commit 819801c into elastic:main Jun 7, 2023
@elasticmachine

elasticmachine commented Jun 7, 2023

Copy link
Copy Markdown

Package panw - 3.10.0 containing this change is available at https://epr.elastic.co/search?package=panw
sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@efd6 @sodhikirti07
panw: allow usernames to contain spaces (#6463)
0454cec 
This exists in the wild, so we should handle it.
@efd6
efd6 deleted the 6172-panw branch February 5, 2025 22:05
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
panw: allow usernames to contain spaces (elastic#6463)
a7b9636 
This exists in the wild, so we should handle it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:panw Palo Alto Next-Gen Firewall

3 participants

@efd6 @elasticmachine @kcreddy