checkpoint: avoid data loss from loguid collisions - #6483
Merged
Conversation
efd6
added
enhancement
Because Checkpoint reuse loguids, it is possible for two logged events to be given the same fingerprint. So use the segment_time as well in the fingerprint args. Also document that if collisions are important, the user should enable semi-unified logging on the device's dashboard.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
efd6
marked this pull request as ready for review
June 6, 2023 04:26
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
kcreddy
approved these changes
Jun 7, 2023
kcreddy
left a comment
kcreddy
left a comment
Contributor
There was a problem hiding this comment.
Minor clarification. LGTM 👍🏼
Comment on lines
+42
to
+43
| In some instances firewall events may have the same Checkpoint `loguid` and arrive during the same timestamp resulting in a fingerprint collision. To avoid this [enable semi-unified logging](https://sc1.checkpoint.com/documents/R81/WebAdminGuides/EN/CP_R81_LoggingAndMonitoring_AdminGuide/Topics-LMG/Log-Exporter-Appendix.htm?TocPath=Log%20Exporter%7C_____9) in the Checkpoint dashboard. | ||
|
|
Contributor
There was a problem hiding this comment.
Does it make sense to add this bit to Troubleshooting section instead? or does it look good here?
https://github.com/elastic/integrations/blob/main/docs/documentation_guidelines.md#troubleshooting
Contributor
Author
There was a problem hiding this comment.
The intention is that this be considered at set-up so that users don't need to get to the stage of trouble-shooting.
|
Package checkpoint - 1.22.0 containing this change is available at https://epr.elastic.co/search?package=checkpoint |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
Because Checkpoint reuse loguids, it is possible for two logged events to be given the same fingerprint. So use the segment_time as well in the fingerprint args. Also document that if collisions are important, the user should enable semi-unified logging on the device's dashboard.
3 tasks
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
Because Checkpoint reuse loguids, it is possible for two logged events to be given the same fingerprint. So use the segment_time as well in the fingerprint args. Also document that if collisions are important, the user should enable semi-unified logging on the device's dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Because Checkpoint reuse loguids, it is possible for two logged events to be given the same fingerprint. So use the segment_time as well in the fingerprint args. Also document that if collisions are important, the user should enable semi-unified logging on the device's dashboard.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots