Skip to content

[AWS] [API Gateway] Logs data stream - #6530

Merged
lucian-ioan merged 14 commits into
elastic:mainfrom
lucian-ioan:add_apigateway_logs
Jul 20, 2023
Merged

[AWS] [API Gateway] Logs data stream#6530
lucian-ioan merged 14 commits into
elastic:mainfrom
lucian-ioan:add_apigateway_logs

Conversation

@lucian-ioan

@lucian-ioan lucian-ioan commented Jun 10, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds logs data stream which collects API Gateway logs from CloudWatch or S3.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@lucian-ioan lucian-ioan self-assigned this Jun 10, 2023
@lucian-ioan lucian-ioan mentioned this pull request Jun 10, 2023
8 tasks
@elasticmachine

elasticmachine commented Jun 10, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-20T10:50:57.477+0000

  • Duration: 54 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 198
Skipped 4
Total 202

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jun 10, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (16/16) 💚
Files 94.118% (16/17) 👎 -3.116
Classes 94.118% (16/17) 👎 -3.116
Methods 85.862% (249/290) 👎 -6.31
Lines 86.001% (7464/8679) 👎 -5.149
Conditionals 100.0% (0/0) 💚
@lucian-ioan
lucian-ioan marked this pull request as ready for review July 4, 2023 06:23
@lucian-ioan
lucian-ioan requested a review from a team as a code owner July 4, 2023 06:23
Comment thread packages/aws/manifest.yml Outdated
@tdancheva

Copy link
Copy Markdown
Contributor

Since @zmoog already picked it up, I will just leave a comment, can you please add a standalone S3 bucket option, like I have done here? You can see this issue. We need to do this for all the data streams where it is missing. I did it for and merged Cloudtrail and vpcflow so far.

@lucian-ioan
lucian-ioan requested a review from zmoog July 19, 2023 16:04
description: The maximum duration of AWS API can take. The maximum is half of the visibility timeout value.
- name: queue_url
type: text
title: Queue URL

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a leftover, I noticed we have two "Queue URL" fields:

image
@lucian-ioan
lucian-ioan requested a review from zmoog July 20, 2023 09:11
@zmoog

zmoog commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

The PR looks good. I missed only one small thing in the last pass: an SQS option at the end of the advanced setting instead of close to the other SQS options.

CleanShot 2023-07-20 at 11 35 20@2x

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only move the SQS option with the others and then LGTM.

@lucian-ioan
lucian-ioan merged commit 72d1474 into elastic:main Jul 20, 2023
@elasticmachine

Copy link
Copy Markdown

Package aws - 1.49.0 containing this change is available at https://epr.elastic.co/search?package=aws

@lucian-ioan lucian-ioan linked an issue Jul 24, 2023 that may be closed by this pull request
8 tasks
@lucian-ioan
lucian-ioan deleted the add_apigateway_logs branch February 6, 2024 14:49
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Add API Gateway logs data stream

* Bump package version

* Fix PR link in changelog entry

* fix manifest

* fix pipeline date format

* fix sample_event

* update docs

* add missing S3 standalone config

* fix fields

* move SQS field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants