Skip to content

[Microsoft SQL Server] Migrate Microsoft SQL Server to GA - #6574

Merged
muthu-mps merged 4 commits into
elastic:mainfrom
muthu-mps:make_microsoftsql_server_ga
Jun 19, 2023
Merged

[Microsoft SQL Server] Migrate Microsoft SQL Server to GA#6574
muthu-mps merged 4 commits into
elastic:mainfrom
muthu-mps:make_microsoftsql_server_ga

Conversation

@muthu-mps

@muthu-mps muthu-mps commented Jun 14, 2023 •
edited by shmsr
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

Migrates the integration data streams from BETA to GA

  • performance
  • transaction_log
  • error_log

How to test this PR locally

  • Install the integration
  • Run system and pipeline tests
  • Verify the data loading in Kibana
  • Verify the BETA flags are removed from the datastreams

Related issues
@elasticmachine

elasticmachine commented Jun 14, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-14T13:59:48.424+0000

  • Duration: 17 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jun 14, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.75% (30/32) 👍 21.023
Lines 100.0% (1251/1251) 💚
Conditionals 100.0% (0/0) 💚
@muthu-mps
muthu-mps marked this pull request as ready for review June 14, 2023 13:41
@muthu-mps
muthu-mps requested a review from a team as a code owner June 14, 2023 13:41
@muthu-mps muthu-mps changed the title [Microsoft Sqlserver] Migrate microsoft Sqlserver GA Jun 14, 2023
milan-elastic
milan-elastic reviewed Jun 14, 2023
View reviewed changes
Comment thread packages/microsoft_sqlserver/changelog.yml Outdated
# newer versions go on top
- version: "2.0.0"
changes:
- description: Make performance, transaction_log & log datastream GA

@milan-elastic milan-elastic Jun 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we keep the "." (fullstop) in the end of the sentences? Please check at the other places as well if its missing.
@elasticmachine

elasticmachine commented Jun 14, 2023

Copy link
Copy Markdown

💚 Build Succeeded

History
milan-elastic
milan-elastic approved these changes Jun 14, 2023
View reviewed changes

@milan-elastic milan-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@shmsr shmsr changed the title [Microsoft Sqlserver] Migrate microsoft Sqlserver to GA Jun 15, 2023
@muthu-mps
muthu-mps merged commit c5ba136 into elastic:main Jun 19, 2023
@elasticmachine

elasticmachine commented Jun 19, 2023

Copy link
Copy Markdown

Package microsoft_sqlserver - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver
@andrewkroh andrewkroh added the Integration:microsoft_sqlserver Microsoft SQL Server label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@muthu-mps
[Microsoft SQL Server] Migrate Microsoft SQL Server to GA (elastic#6574)
dba1e7a 
* migrate microsoft sqlserver GA

* update changelog entry

* include log datastream

* review comments addressed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:microsoft_sqlserver Microsoft SQL Server

5 participants

@muthu-mps @elasticmachine @shmsr @milan-elastic @andrewkroh