Skip to content

[thycotic_ss] Ensure event.kind is correctly set for pipeline errors - #6658

Merged
efd6 merged 4 commits into
elastic:mainfrom
MakoWish:6582-thycotic_ss
Jun 21, 2023
Merged

[thycotic_ss] Ensure event.kind is correctly set for pipeline errors#6658
efd6 merged 4 commits into
elastic:mainfrom
MakoWish:6582-thycotic_ss

Conversation

@MakoWish

Copy link
Copy Markdown
Contributor

What does this PR do?

Modify thycotic_ss integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish
MakoWish requested a review from a team as a code owner June 21, 2023 22:56
@elasticmachine

elasticmachine commented Jun 21, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T23:08:53.655+0000

  • Duration: 15 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6

efd6 commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (13/13) 💚 3.101
Lines 72.922% (272/373) 👎 -22.336
Conditionals 100.0% (0/0) 💚
@efd6
efd6 merged commit c28b3a2 into elastic:main Jun 21, 2023
@elasticmachine

Copy link
Copy Markdown

Package thycotic_ss - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=thycotic_ss

@MakoWish
MakoWish deleted the 6582-thycotic_ss branch June 22, 2023 14:24
@andrewkroh andrewkroh added the Integration:thycotic_ss Thycotic Secret Server (Community supported) label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:thycotic_ss Thycotic Secret Server (Community supported)

4 participants