Skip to content

[qrs]*: ensure event.kind is correctly set for pipeline errors - #6663

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:6582-qrs
Jun 22, 2023
Merged

[qrs]*: ensure event.kind is correctly set for pipeline errors#6663
efd6 merged 1 commit into
elastic:mainfrom
efd6:6582-qrs

Conversation

@efd6

@efd6 efd6 commented Jun 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Modify qnap_nas, radware, santa, sentinel_one, slack, snort, snyk, sonicwall_firewall, sophos, sophos_central, squid, symantec_endpoint and sysmon_linux to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Jun 22, 2023
@efd6
efd6 force-pushed the 6582-qrs branch 2 times, most recently from f87fb49 to 78a253b Compare June 22, 2023 03:16
@efd6 efd6 mentioned this pull request Jun 22, 2023
Closed
@elasticmachine

elasticmachine commented Jun 22, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-22T04:19:30.612+0000

  • Duration: 20 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 173
Skipped 3
Total 176

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jun 22, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (19/19) 💚
Files 100.0% (32/32) 💚 2.817
Classes 100.0% (32/32) 💚 2.817
Methods 97.384% (335/344) 👍 0.924
Lines 91.943% (9700/10550) 👎 -0.538
Conditionals 100.0% (0/0) 💚
@efd6
[qrs]*: ensure event.kind is correctly set for pipeline errors
a3f64ea 
qnap_nas, radware, santa, sentinel_one, slack, snort, snyk, sonicwall_firewall,
sophos, sophos_central, squid, symantec_endpoint, sysmon_linux
@efd6
efd6 marked this pull request as ready for review June 22, 2023 04:42
@efd6
efd6 requested a review from a team as a code owner June 22, 2023 04:42
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
bhapas
bhapas approved these changes Jun 22, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6
efd6 merged commit 4cff5c1 into elastic:main Jun 22, 2023
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package qnap_nas - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=qnap_nas
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package radware - 0.15.0 containing this change is available at https://epr.elastic.co/search?package=radware
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package santa - 3.8.0 containing this change is available at https://epr.elastic.co/search?package=santa
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package sentinel_one - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=sentinel_one
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package slack - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=slack
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package snort - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=snort
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package snyk - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=snyk
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package sonicwall_firewall - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=sonicwall_firewall
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package sophos - 2.10.0 containing this change is available at https://epr.elastic.co/search?package=sophos
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package sophos_central - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=sophos_central
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package squid - 0.16.0 containing this change is available at https://epr.elastic.co/search?package=squid
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package symantec_endpoint - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=symantec_endpoint
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

Package sysmon_linux - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=sysmon_linux
@efd6
efd6 deleted the 6582-qrs branch February 5, 2025 22:08
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
[qrs]*: ensure event.kind is correctly set for pipeline errors (elast…
6d6348e 
…ic#6663)

qnap_nas, radware, santa, sentinel_one, slack, snort, snyk, sonicwall_firewall,
sophos, sophos_central, squid, symantec_endpoint, sysmon_linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants

@efd6 @elasticmachine @bhapas