Skip to content

[AWS][S3] Add metric_type metadata to s3_daily_storage and s3_request data streams - #6667

Merged
tetianakravchenko merged 4 commits into
elastic:mainfrom
tetianakravchenko:aws-s3-metrics
Jun 29, 2023
Merged

[AWS][S3] Add metric_type metadata to s3_daily_storage and s3_request data streams#6667
tetianakravchenko merged 4 commits into
elastic:mainfrom
tetianakravchenko:aws-s3-metrics

Conversation

@tetianakravchenko

Copy link
Copy Markdown
Contributor

What does this PR do?

Add metric_type metadata to s3_daily_storage and s3_request data streams
All of metrics are of type gauge, since there is used an aggregation to gather those metrics - https://github.com/elastic/beats/blob/main/x-pack/metricbeat/module/aws/s3_daily_storage/manifest.yml#L7-L11

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
tetianakravchenko requested a review from a team as a code owner June 22, 2023 09:08
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-29T08:25:40.409+0000

  • Duration: 51 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine

elasticmachine commented Jun 22, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) ��
Files 93.75% (15/16) 👎 -2.769
Classes 93.75% (15/16) 👎 -2.769
Methods 85.714% (240/280) 👎 -3.537
Lines 85.925% (7387/8597) 👎 -6.047
Conditionals 100.0% (0/0) 💚
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
tetianakravchenko requested a review from a team June 29, 2023 08:25
@tetianakravchenko
tetianakravchenko merged commit 06d4611 into elastic:main Jun 29, 2023
@tetianakravchenko
tetianakravchenko deleted the aws-s3-metrics branch June 29, 2023 16:23
@elasticmachine

Copy link
Copy Markdown

Package aws - 1.45.8 containing this change is available at https://epr.elastic.co/search?package=aws

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
… data streams (elastic#6667)

* add metric_type metadata to s3_daily_storage and s3_request data streams

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix pr link; run elastic-package build

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

6 participants