Skip to content

sophos: fix handling of date parsing - #6676

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:6546-sophos
Jun 23, 2023
Merged

sophos: fix handling of date parsing#6676
efd6 merged 1 commit into
elastic:mainfrom
efd6:6546-sophos

Conversation

@efd6

@efd6 efd6 commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Ensure fields that have been defined as date are parseable as date. Also add timezone configuration and progressively determine timezone from logs, config, locale.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues enhancement New feature or request Team:Security-External Integrations Integration:sophos Sophos labels Jun 23, 2023
@efd6 efd6 self-assigned this Jun 23, 2023
@elasticmachine

elasticmachine commented Jun 23, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-23T01:08:04.940+0000

  • Duration: 19 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (13/13) 💚
Classes 100.0% (13/13) 💚
Methods 98.901% (90/91) 👍 0.037
Lines 93.776% (1808/1928) 👍 3.07
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review June 23, 2023 01:57
@efd6
efd6 requested a review from a team as a code owner June 23, 2023 01:57
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
efd6 merged commit 9be4dab into elastic:main Jun 23, 2023
@elasticmachine

Copy link
Copy Markdown

Package sophos - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=sophos

1 similar comment
@elasticmachine

Copy link
Copy Markdown

Package sophos - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=sophos

@efd6
efd6 deleted the 6546-sophos branch February 5, 2025 22:08
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues enhancement New feature or request Integration:sophos Sophos

3 participants