[m365_defender] Fix event.query type to group - #6696
Merged
Conversation
bhapas
added
Team:Security-External Integrations
Integration:m365_defender
bhapas
force-pushed
the
sdh-3427-query-mapping
branch
from
June 26, 2023 08:14
b479b1c to
56cd8b9
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
bhapas
marked this pull request as ready for review
June 26, 2023 08:29
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
|
/test |
|
Package m365_defender - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
andrewkroh
reviewed
Jun 26, 2023
| type: ip | ||
| description: Public IP address used by the onboarded machine to connect to the Microsoft Defender for Endpoint service. This could be the IP address of the machine itself, a NAT device, or a proxy. | ||
| - name: query | ||
| type: keyword |
Contributor
There was a problem hiding this comment.
Any field definition that contains fields and is not marked as type: group should be considered an error. I can't think of any valid use case to allow this. Can you @jsoriano? I'm thinking this might be a good candidate for a package-spec validation rule if there are no exceptions to the rule.
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the
m365_defender.event.querytype togroupinstead ofkeyword. This blocked ingesting all the documents that contained this as agroupChecklist
I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's
changelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.
Closes [m365_defender] event.query wrongly mapped to keyword in fields.yml #6695