Skip to content

[zscaler_zia] Update mapping for user.name and host.hostname - #6820

Merged
efd6 merged 4 commits into
elastic:mainfrom
piyush-elastic:zscaler_zia-2.11.1
Jul 30, 2023
Merged

[zscaler_zia] Update mapping for user.name and host.hostname#6820
efd6 merged 4 commits into
elastic:mainfrom
piyush-elastic:zscaler_zia-2.11.1

Conversation

@piyush-elastic

@piyush-elastic piyush-elastic commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Type of change

  • Bugfix

What does this PR do?

Update mapping for user.name and host.hostname

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone integrations repo.
Install elastic package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/zscaler_zia directory.
Run the following command to run tests.

Related issues

Automated Test

zscaler_test.txt

@piyush-elastic
piyush-elastic requested a review from a team as a code owner July 5, 2023 09:13
@elasticmachine

elasticmachine commented Jul 5, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-18T12:15:17.791+0000

  • Duration: 22 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jul 5, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (70/70) 💚 33.333
Lines 93.251% (1589/1704) 👎 -6.749
Conditionals 100.0% (0/0) 💚
ignore_failure: true
- foreach:
field: user.name
if: ctx.user?.name != null && ctx.user.name instanceof List

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: ctx.user?.name != null && ctx.user.name instanceof List
if: ctx.user?.name instanceof List
ignore_failure: true
- foreach:
field: user.name
if: ctx.user?.name != null && ctx.user.name instanceof List

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: ctx.user?.name != null && ctx.user.name instanceof List
if: ctx.user?.name instanceof List
Comment on lines +149 to +151
"host": {
"name": "TestMachine35"
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase FQDN? or just lc if FQDN not available. https://www.elastic.co/guide/en/ecs/current/ecs-host.html#field-host-name

ignore_failure: true
- foreach:
field: user.name
if: ctx.user?.name != null && ctx.user.name instanceof List

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: ctx.user?.name != null && ctx.user.name instanceof List
if: ctx.user?.name instanceof List
@piyush-elastic
piyush-elastic requested a review from efd6 July 18, 2023 12:37

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
efd6 merged commit 67f64f1 into elastic:main Jul 30, 2023
@elasticmachine

Copy link
Copy Markdown

Package zscaler_zia - 2.11.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia

@andrewkroh andrewkroh added the Integration:zscaler_zia Zscaler Internet Access label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:zscaler_zia Zscaler Internet Access

4 participants