[Kubenretes Integration] Adding deployment condition status in kube state deployment dataset by gizas · Pull Request #6821 · elastic/integrations

gizas · 2023-07-05T10:13:49Z

**** DONT MERGE UNTIL 8.10 is released****

Enhancement

What does this PR do?

Introduces in Kubernetes Integration the new deployment condition status field

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

See inforamtion here: elastic/elastic-agent#2995

Related issues

elasticmachine · 2023-07-05T10:31:30Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-09-05T10:25:02.189+0000
Duration: 53 min 5 sec

Test stats 🧪

Test	Results
Failed	0
Passed	92
Skipped	0
Total	92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

tetianakravchenko · 2023-07-05T10:39:30Z

 release: ga
 conditions:
-  kibana.version: "^8.8.0"
+  kibana.version: "^8.8.2"


are you planning to backport elastic/beats#35999 to this version? I believe 8.8.2 was already released, so it will not land in 8.8.2, isn't it?

Deliberately made because this field will be present only when elastic/beats#35999 is merged.
And yes we will need a version later than 8.8.2. Is not that correct?

We don't need to update the kibana version as we are not using any new kibana feature for this. The new fields will start get populated in version beats 8.10. But that doesn't mean we need to set it to 8.10 in the kibana version constraints. Until the agent 8.10 is released the added fields will not be populated. If we set the version to 8.10 here, then we won't be able to introduce new immediate changes to the integration.

Makes sense! Thanks for clarifications @MichaelKatsoulis .

Reverted change for kibana. Thank you both

It's more correct if we set this to 8.10. Otherwise the new package's version will mention in the docs the new field but this will not be populated right? I believe fields' docs should be aligned with the features.

Not having the option to do changes for previous versions is a known issue but we should not deliver inaccurate packages just to by pass this.

So you are suggesting to freeze this PR until 8.10 gets released or until we need to update the kibana constraint for a different PR ? Because just putting 8.10 now prevents us from any other update targeting to 8.9 or 8.8

Freezing it won't be a real problem as long as the feature is not yet released, right?

So I'm suggesting to either freeze it or/and raise this conversation to a wider audience to make sure that we have a solid process to handle cases like these in the future.

Yes let's freeze this until it makes sense.

So by reading the above discussion:

We will keep the kibana constrain to "^8.8.0"

Wait until 8.10 is released and then merge this integration

Raise a question in today's meeting call: "how we handle integrations upgrades that need to match specific beats version?"

You will also need to update the constrain.

So it's: Wait until 8.10 is released and then merge this integration with 8.10.0 constrain.

elasticmachine · 2023-07-05T10:45:40Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`0/0`)	💚
Files	100.0% (`0/0`)	💚 3.358
Classes	100.0% (`0/0`)	💚 3.358
Methods	96.154% (`75/78`)	👍 3.83
Lines	100.0% (`0/0`)	💚 11.73
Conditionals	100.0% (`0/0`)	💚

ChrsMark

Since we agree on this let's stall the PR for now.

kibana.version should be ^8.10.0 for this be merged.

botelastic · 2023-08-05T14:14:15Z

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

botelastic · 2023-09-04T15:14:19Z

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

gizas · 2023-09-05T07:18:45Z

Reopening and updated constrain to ^8.10.0 as per discusion above.
See 362cc4a

ChrsMark

LGTM

elasticmachine · 2023-09-05T11:57:38Z

Package kubernetes - 1.44.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

…tate deployment dataset (elastic#6821) * adding deployment condition status * updating changelog * reverting kibana version * fixing conflicts

gizas requested a review from a team as a code owner July 5, 2023 10:13

gizas requested review from constanca-m and devamanv July 5, 2023 10:13

gizas self-assigned this Jul 5, 2023

gizas added the Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] label Jul 5, 2023

gizas changed the title ~~adding deployment condition status~~ Jul 5, 2023

This was referenced Jul 5, 2023

Introducing Deployment condition status metric in Kubernetes module elastic/beats#35999

Merged

Adding deployment condition status field in kube State Deployment metricset elastic/elastic-agent#2995

Closed

tetianakravchenko reviewed Jul 5, 2023

View reviewed changes

MichaelKatsoulis approved these changes Jul 5, 2023

View reviewed changes

ChrsMark mentioned this pull request Jul 6, 2023

Enrich kubernetes events with involved_object related fields #6817

Closed

ChrsMark requested changes Jul 6, 2023

View reviewed changes

botelastic Bot added the Stalled label Aug 5, 2023

botelastic Bot closed this Sep 4, 2023

gizas reopened this Sep 5, 2023

botelastic Bot removed the Stalled label Sep 5, 2023

gizas requested review from a team as code owners September 5, 2023 09:38

gizas added 3 commits September 5, 2023 12:44

adding deployment condition status

265407d

updating changelog

90dab68

reverting kibana version

b64cd98

gizas force-pushed the deployment_condition branch from 9aa4df4 to b64cd98 Compare September 5, 2023 10:06

fixing conflicts

274062a

ChrsMark reviewed Sep 5, 2023

View reviewed changes

Comment thread packages/kubernetes/changelog.yml

ChrsMark approved these changes Sep 5, 2023

View reviewed changes

gizas removed request for a team September 5, 2023 10:21

Removing license from kubernetes/manifest.yml

41e888a

gizas merged commit 2b9a50f into main Sep 5, 2023

gizas deleted the deployment_condition branch September 5, 2023 11:35

tetianakravchenko mentioned this pull request Sep 27, 2023

[Azure][Storage_account] Add dimension to the storage account datastream #7356

Merged

4 tasks

andrewkroh added the Integration:kubernetes Kubernetes label Jul 22, 2024

Navigation Menu

Uh oh!

[Kubenretes Integration] Adding deployment condition status in kube state deployment dataset - #6821

[Kubenretes Integration] Adding deployment condition status in kube state deployment dataset#6821
gizas merged 5 commits into
mainfrom
deployment_condition

gizas commented Jul 5, 2023 •

edited

Loading

elasticmachine commented Jul 5, 2023 •

edited

Loading

Build stats

Test stats 🧪

tetianakravchenko Jul 5, 2023

gizas Jul 5, 2023

MichaelKatsoulis Jul 5, 2023

gizas Jul 5, 2023

ChrsMark Jul 5, 2023 •

edited

Loading

MichaelKatsoulis Jul 5, 2023

ChrsMark Jul 5, 2023

MichaelKatsoulis Jul 6, 2023

gizas Jul 6, 2023

ChrsMark Jul 6, 2023

elasticmachine commented Jul 5, 2023 •

edited

Loading

ChrsMark left a comment •

edited

Loading

botelastic Bot commented Aug 5, 2023

botelastic Bot commented Sep 4, 2023

gizas commented Sep 5, 2023

Uh oh!

ChrsMark left a comment

elasticmachine commented Sep 5, 2023

Labels

7 participants

Uh oh!

Conversation

gizas commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

How to test this PR locally

Related issues

elasticmachine commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChrsMark Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

ChrsMark left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

botelastic Bot commented Aug 5, 2023

botelastic Bot commented Sep 4, 2023

gizas commented Sep 5, 2023

Uh oh!

ChrsMark left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 5, 2023

Labels

7 participants

gizas commented Jul 5, 2023 •

edited

Loading

elasticmachine commented Jul 5, 2023 •

edited

Loading

ChrsMark Jul 5, 2023 •

edited

Loading

elasticmachine commented Jul 5, 2023 •

edited

Loading

ChrsMark left a comment •

edited

Loading