[azure] Handle DNAT log with policy/rgc/rc/rule attributes - #6824
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
dmathieu
force-pushed
the
azure-firewall-dnat
branch
from
July 5, 2023 14:12
661bcbe to
0233e7f
Compare
dmathieu
marked this pull request as ready for review
July 5, 2023 14:30
tdancheva
approved these changes
Jul 5, 2023
tdancheva
left a comment
tdancheva
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I looked at the SDH, should solve one of the issues.
|
Package azure - 1.5.24 containing this change is available at https://epr.elastic.co/search?package=azure |
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
* handle DNAT log with policy/rgc/rc/rule attributes * add changelog entry * test new dnat rule * bump manifest version * add missing attributes to expected file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DNAT log entries from Azure may include the
Policy,Rule Collection Group,Rule CollectionandRuleattributes.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Install the plugin, and generate firewall requests that get DNAT'ed.
This is also unit tested with the expected json tests.
Related issues
Screenshots