Skip to content

[azure] Ensure user_agent.original cannot be duplicated - #6867

Merged
dmathieu merged 2 commits into
mainfrom
unique-user-agent
Jul 10, 2023
Merged

[azure] Ensure user_agent.original cannot be duplicated#6867
dmathieu merged 2 commits into
mainfrom
unique-user-agent

Conversation

@dmathieu

@dmathieu dmathieu commented Jul 7, 2023

Copy link
Copy Markdown
Member

What does this PR do?

This is the same fix as #5361 and #6866, but for the user_agent.original field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Run the following query in the dev tools:

POST _ingest/pipeline/logs-azure.signinlogs-1.5.26/_simulate
{
  "docs": [
    {
      "_source": {
        "message": {
          "properties": {
            "user_agent": "NCSA_Mosaic/2.0 (Windows 3.1)"
          }
        },
        "user_agent": {
          "original": "Stone Tablet (Paleolithic)"
        }
      }
    }
  ]
}

Related issues

Screenshots

@dmathieu dmathieu added the bugfix Pull request that fixes a bug issue label Jul 7, 2023
@dmathieu
dmathieu requested a review from a team as a code owner July 7, 2023 11:52
@dmathieu dmathieu changed the title ensure user_agent.original cannot be duplicated Jul 7, 2023
@andrewkroh andrewkroh changed the title Ensure user_agent.original cannot be duplicated Jul 7, 2023
@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 7, 2023
@elasticmachine

elasticmachine commented Jul 7, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-10T08:06:19.144+0000

  • Duration: 13 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jul 7, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👎 -15.297
Lines 85.003% (2817/3314) 👎 -8.25
Conditionals 100.0% (0/0) 💚
@dmathieu
dmathieu merged commit 9dc8723 into main Jul 10, 2023
@dmathieu
dmathieu deleted the unique-user-agent branch July 10, 2023 08:19
@elasticmachine

Copy link
Copy Markdown

Package azure - 1.5.26 containing this change is available at https://epr.elastic.co/search?package=azure

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:azure Azure Logs

4 participants