Skip to content

o365: convert visualisations to lens - #6902

Merged
efd6 merged 3 commits into
elastic:mainfrom
efd6:6787-o365
Jul 12, 2023
Merged

o365: convert visualisations to lens#6902
efd6 merged 3 commits into
elastic:mainfrom
efd6:6787-o365

Conversation

@efd6

@efd6 efd6 commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-07-11 at 12 13 29
@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:o365 Microsoft Office 365 labels Jul 11, 2023
@efd6 efd6 self-assigned this Jul 11, 2023
efd6 added 3 commits July 11, 2023 12:25
@efd6
o365: update dashboards to kibana.version 8.7.1
d86c850
@efd6
o365: convert visualisations to lens
04247b1 
One visualisation was adjusted to use a donut rather than a histogram,
with full outcomes rather than only failures.
@efd6
o356: manual edit to remove kibana conversion scars
b070264 
These were edited in the UI but this does not get reflected in the saved files.
@efd6 efd6 mentioned this pull request Jul 11, 2023
Closed
36 tasks
@elasticmachine

elasticmachine commented Jul 11, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-11T02:56:28.056+0000

  • Duration: 15 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 11, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.667
Classes 100.0% (1/1) 💚 2.667
Methods 100.0% (16/16) 💚 7.108
Lines 82.155% (732/891) 👎 -8.845
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review July 11, 2023 03:15
@efd6
efd6 requested a review from a team as a code owner July 11, 2023 03:15
@elasticmachine

elasticmachine commented Jul 11, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kcreddy
kcreddy reviewed Jul 12, 2023
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6
efd6 merged commit 6e2c0f9 into elastic:main Jul 12, 2023
@elasticmachine

elasticmachine commented Jul 12, 2023

Copy link
Copy Markdown

Package o365 - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=o365
@efd6
efd6 deleted the 6787-o365 branch February 5, 2025 22:11
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
o365: convert visualisations to lens (elastic#6902)
6ff434d 
One visualisation was adjusted to use a donut rather than a histogram,
with full outcomes rather than only failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:o365 Microsoft Office 365

3 participants

@efd6 @elasticmachine @kcreddy