Skip to content

Fix Firewall dashboards - #6960

Merged
tdancheva merged 2 commits into
elastic:mainfrom
tdancheva:fix-firewall-dashboards
Jul 17, 2023
Merged

Fix Firewall dashboards#6960
tdancheva merged 2 commits into
elastic:mainfrom
tdancheva:fix-firewall-dashboards

Conversation

@tdancheva

@tdancheva tdancheva commented Jul 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR fixes a typo, replacing azure.account.id with cloud.account.id.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@tdancheva tdancheva added the bug Something isn't working, use only for issues label Jul 14, 2023
@tdancheva
tdancheva marked this pull request as ready for review July 14, 2023 08:41
@tdancheva
tdancheva requested a review from a team as a code owner July 14, 2023 08:41
@elasticmachine

elasticmachine commented Jul 14, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-14T08:40:25.665+0000

  • Duration: 15 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 14, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) ❕
Classes 86.364% (19/22) ❕
Methods 83.333% (155/186) ❕
Lines 85.003% (2817/3314) ❕
Conditionals 100.0% (0/0) 💚
@tdancheva
tdancheva merged commit 3c0feb7 into elastic:main Jul 17, 2023
@tdancheva
tdancheva deleted the fix-firewall-dashboards branch July 17, 2023 07:20
@elasticmachine

elasticmachine commented Jul 17, 2023

Copy link
Copy Markdown

Package azure - 1.5.27 containing this change is available at https://epr.elastic.co/search?package=azure
@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@tdancheva
Fix Firewall dashboards (elastic#6960)
9ba9a83 
* Fix Firewall dashboards

* Changelog and manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:azure Azure Logs

4 participants

@tdancheva @elasticmachine @kaiyan-sheng @andrewkroh