Skip to content

[aws] Ensure event.kind is correctly set for pipeline errors - #7039

Closed
MakoWish wants to merge 17 commits into
elastic:mainfrom
MakoWish:6582-aws
Closed

[aws] Ensure event.kind is correctly set for pipeline errors#7039
MakoWish wants to merge 17 commits into
elastic:mainfrom
MakoWish:6582-aws

Conversation

@MakoWish

@MakoWish MakoWish commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Modify aws integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish
MakoWish requested a review from a team as a code owner July 20, 2023 15:31
@elasticmachine

elasticmachine commented Jul 20, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-29T21:19:18.153+0000

  • Duration: 50 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@MakoWish
MakoWish requested a review from a team as a code owner August 14, 2023 16:02
@elasticmachine

elasticmachine commented Aug 28, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -5.556
Classes 94.444% (17/18) 👎 -5.556
Methods 86.047% (259/301) 👎 -13.953
Lines 86.069% (7562/8786) 👍 17.59
Conditionals 100.0% (0/0) 💚
@botelastic

botelastic Bot commented Sep 29, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label Sep 29, 2023
@botelastic botelastic Bot removed the Stalled label Sep 29, 2023
field: aws.rds.metrics.AuroraVolumeBytesLeftTotal.avg
target_field: aws.rds.aurora_volume_left_total.bytes
ignore_missing: true
- remove:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmoog Correct me if Im wrong please, I thought rename automatically remove the old fields. So no need to add remove here anymore.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why that remove processor is showing as added in my branch. I did not add those. Did another PR remove them, so now my changes appear to be adding them again?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh ok lets remove them from this PR then :) Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! :-)

@botelastic

botelastic Bot commented Nov 8, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label Nov 8, 2023
@botelastic

botelastic Bot commented Dec 11, 2023

Copy link
Copy Markdown

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic Bot closed this Dec 11, 2023
@MakoWish
MakoWish deleted the 6582-aws branch February 4, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment