Skip to content

[azure_metrics] Ensure event.kind is correctly set for pipeline errors - #7043

Closed
MakoWish wants to merge 7 commits into
elastic:mainfrom
MakoWish:6582-azure_metrics
Closed

[azure_metrics] Ensure event.kind is correctly set for pipeline errors#7043
MakoWish wants to merge 7 commits into
elastic:mainfrom
MakoWish:6582-azure_metrics

Conversation

@MakoWish

@MakoWish MakoWish commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Modify azure_metrics integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish
MakoWish requested a review from a team as a code owner July 20, 2023 15:45
@elasticmachine

elasticmachine commented Jul 20, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-27T20:44:43.893+0000

  • Duration: 14 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Aug 28, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 5.556
Classes 100.0% (4/4) 💚 5.556
Methods 75.758% (25/33) 👎 -10.196
Lines 100.0% (32/32) 💚 13.961
Conditionals 100.0% (0/0) 💚
@botelastic

botelastic Bot commented Sep 27, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label Sep 27, 2023
@MakoWish

Copy link
Copy Markdown
Contributor Author

@zmoog,

I don't have permissions to /test or to merge. I just incremented the version to resolve conflicts. Can you /test again, and merge once done?

@botelastic botelastic Bot removed the Stalled label Sep 27, 2023
@botelastic

botelastic Bot commented Oct 27, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label Oct 27, 2023
@botelastic

botelastic Bot commented Nov 26, 2023

Copy link
Copy Markdown

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic Bot closed this Nov 26, 2023
@MakoWish
MakoWish deleted the 6582-azure_metrics branch February 4, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants