Skip to content

[AbuseCH] Empty Strings Causing False Positives with Threat Intel Hash Indicator Match Rule - #7103

Merged
efd6 merged 6 commits into
elastic:mainfrom
MakoWish:abusech_empty_strings
Jul 24, 2023
Merged

[AbuseCH] Empty Strings Causing False Positives with Threat Intel Hash Indicator Match Rule#7103
efd6 merged 6 commits into
elastic:mainfrom
MakoWish:abusech_empty_strings

Conversation

@MakoWish

@MakoWish MakoWish commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

What does this PR do?

This PR adds a script processor to remove fields with empty string values to resolve false-positives with the Threat Intel Hash Indicator Match Detection Rule.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@MakoWish
MakoWish requested a review from a team as a code owner July 21, 2023 18:42
@elasticmachine

elasticmachine commented Jul 21, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-24T22:17:35.914+0000

  • Duration: 17 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@MakoWish MakoWish changed the title Abusech empty strings Jul 21, 2023
@efd6

efd6 commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (51/51) 💚
Lines 89.929% (509/566)
Conditionals 100.0% (0/0) 💚
@efd6

efd6 commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

/test

@efd6
efd6 merged commit 155e8c3 into elastic:main Jul 24, 2023
@elasticmachine

Copy link
Copy Markdown

Package ti_abusech - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=ti_abusech

@MakoWish
MakoWish deleted the abusech_empty_strings branch July 25, 2023 15:32
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants