Skip to content

[AWS] Fix dashboards metric charts - #7129

Merged
8 commits merged into
mainfrom
unknown repository
Aug 10, 2023
Merged

[AWS] Fix dashboards metric charts#7129
8 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 24, 2023

Copy link
Copy Markdown

What does this PR do?

Some dashboards were migrated to the newer metric chart type with color #FFF and they don't work well for the dark Kibana theme - they should use the default metric chart color.

  • Firewall metrics dashboard
  • NATGateway metrics dashboard
  • EC2 metrics dashboard
  • ELB metrics dashboard

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine

elasticmachine commented Jul 24, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-10T12:42:49.835+0000

  • Duration: 55 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 4
Total 210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jul 24, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18)
Classes 94.444% (17/18)
Methods 85.953% (257/299)
Lines 86.011% (7501/8721)
Conditionals 100.0% (0/0) 💚
@ghost
ghost marked this pull request as ready for review July 24, 2023 21:20
@ghost
ghost requested review from a team as code owners July 24, 2023 21:20
@ghost ghost self-assigned this Jul 24, 2023

@mbondyra mbondyra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@drewdaemon

Copy link
Copy Markdown
Contributor

@elastic/obs-cloud-monitoring could we get a review here?

@ghost
ghost self-requested a review as a code owner August 10, 2023 12:42
@ghost
ghost merged commit 1f96d4f into elastic:main Aug 10, 2023
@elasticmachine

Copy link
Copy Markdown

Package aws - 1.52.1 containing this change is available at https://epr.elastic.co/search?package=aws

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* fix firewall_metrics dashboard metric charts color

* fix natgateway metrics dashboard metric charts color

* fix EC2 metrics dashboard metric charts color

* fix elb metrics dashboard metric charts color

* bump package version

* fix PR link in changelog
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

6 participants