Skip to content

[AbuseCH] Bug in Initial Interval for ThreatFox DataSet - #7143

Merged
efd6 merged 2 commits into
elastic:mainfrom
MakoWish:ti_abusech_threatfox
Jul 26, 2023
Merged

[AbuseCH] Bug in Initial Interval for ThreatFox DataSet#7143
efd6 merged 2 commits into
elastic:mainfrom
MakoWish:ti_abusech_threatfox

Conversation

@MakoWish

@MakoWish MakoWish commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

What does this PR do?

This PR changes the default value for "Initial Interval" from 30 to 7, changes the note of valid values from "1-90" to "1-7" and forces the value to integer.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@MakoWish MakoWish changed the title Ti abusech threatfox Jul 25, 2023
@MakoWish
MakoWish marked this pull request as ready for review July 25, 2023 18:45
@MakoWish
MakoWish requested a review from a team as a code owner July 25, 2023 18:45
@elasticmachine

elasticmachine commented Jul 25, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-26T03:30:20.977+0000

  • Duration: 17 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@MakoWish
MakoWish marked this pull request as draft July 25, 2023 20:15
@MakoWish MakoWish closed this Jul 25, 2023
@MakoWish MakoWish reopened this Jul 25, 2023
@MakoWish
MakoWish marked this pull request as ready for review July 25, 2023 20:25
@efd6

efd6 commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

/test
@elasticmachine

elasticmachine commented Jul 26, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (51/51) 💚 8.554
Lines 89.929% (509/566) 👎 -1.561
Conditionals 100.0% (0/0) 💚
efd6
efd6 approved these changes Jul 26, 2023
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@efd6
efd6 merged commit 878927b into elastic:main Jul 26, 2023
@elasticmachine

elasticmachine commented Jul 26, 2023

Copy link
Copy Markdown

Package ti_abusech - 1.15.2 containing this change is available at https://epr.elastic.co/search?package=ti_abusech
@MakoWish
MakoWish deleted the ti_abusech_threatfox branch July 26, 2023 16:21
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@MakoWish
Change ThreatFox initial interval to integer and note valid values 1-7 (
67a61d6 
elastic#7143)

API details from https://threatfox.abuse.ch/api/

"Number of days to filter IOCs for (based on first_seen) Min: 1, Max: 7. Default: 3"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:ti_abusech abuse.ch

4 participants

@MakoWish @elasticmachine @efd6 @andrewkroh