Skip to content

[Azure][Container_registry] Add dimension and metric_type metadata to the container_registry datastream - #7155

Merged
tetianakravchenko merged 5 commits into
elastic:mainfrom
tetianakravchenko:azure-container-registry-tsdb
Aug 16, 2023
Merged

[Azure][Container_registry] Add dimension and metric_type metadata to the container_registry datastream#7155
tetianakravchenko merged 5 commits into
elastic:mainfrom
tetianakravchenko:azure-container-registry-tsdb

Conversation

@tetianakravchenko

@tetianakravchenko tetianakravchenko commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine

elasticmachine commented Jul 26, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-16T15:55:32.112+0000

  • Duration: 14 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jul 26, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👍
Lines 100.0% (21/21) 💚
Conditionals 100.0% (0/0) 💚
@zmoog

zmoog commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

@tetianakravchenko I see #7162 it is the tracking issue for the timegrain problem.

Do you see this problem as a blocker for this PR?

@agithomas

Copy link
Copy Markdown
Contributor

Which field will hold the names of the images, tags, other meta data information ? Shouldn't they be dimensions?

@andrewkroh andrewkroh added the Integration:azure Azure Logs label Aug 1, 2023
@tetianakravchenko

Copy link
Copy Markdown
Contributor Author

@agithomas

Which field will hold the names of the images, tags, other meta data information ? Shouldn't they be dimensions?

There is no such information available in this datastream, here is the list of metrics - https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerregistry-registries-metrics

as you see those metrics are on the registry level, not for each specific image

all available fields:
Screenshot 2023-08-02 at 12 41 53

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko

Copy link
Copy Markdown
Contributor Author

/test

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
tetianakravchenko merged commit 0cd1a8e into elastic:main Aug 16, 2023
@tetianakravchenko
tetianakravchenko deleted the azure-container-registry-tsdb branch August 16, 2023 16:14
@elasticmachine

Copy link
Copy Markdown

Package azure_metrics - 1.0.22 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

- name: agent_pool_cpu_time.total
type: float
metric_type: gauge
unis: s

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "unis" should be "unit".

@andrewkroh andrewkroh added Integration:azure_metrics Azure Resource Metrics and removed Integration:azure Azure Logs labels Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
… the container_registry datastream (elastic#7155)

* registry: add dimensions

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* remove metrics.* field; add agent.id field; add full list of metrics

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:azure_metrics Azure Resource Metrics

6 participants