Skip to content

[mysql_enterprise] - update package-spec to 2.9.0 - #7166

Merged
taylor-swanson merged 5 commits into
elastic:mainfrom
taylor-swanson:pkg-spec-mysql_enterprise
Aug 1, 2023
Merged

[mysql_enterprise] - update package-spec to 2.9.0#7166
taylor-swanson merged 5 commits into
elastic:mainfrom
taylor-swanson:pkg-spec-mysql_enterprise

Conversation

@taylor-swanson

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Update package spec to 2.9.0
[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=v8.8.0 -format-version=2.9.0 packages/mysql_enterprise

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • Relates elastic/security-team#5870
[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=v8.8.0 -format-version=2.9.0 packages/mysql_enterprise
@elasticmachine

elasticmachine commented Jul 27, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-31T15:59:46.392+0000

  • Duration: 15 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jul 27, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (13/13) 💚
Lines 95.283% (202/212)
Conditionals 100.0% (0/0) 💚
@taylor-swanson
taylor-swanson marked this pull request as ready for review July 27, 2023 16:33
@taylor-swanson
taylor-swanson requested a review from a team as a code owner July 27, 2023 16:33
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Comment thread packages/mysql_enterprise/data_stream/audit/sample_event.json
efd6
efd6 previously approved these changes Jul 27, 2023
@efd6
efd6 dismissed their stale review July 27, 2023 21:33

found failure

@efd6

efd6 commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

I stopped watching the tests too early, running this on v8.8.2 I see this:

FAILURE DETAILS:
mysql_enterprise/audit logfile:
[0] parsing field value failed: field "event.type" value "connection" is not one of the expected values (access, change, info, error) for any of the values of "event.category" (database)
[1] parsing field value failed: field "event.type" value "connection" is not one of the expected values (access, change, info, error, admin, creation, deletion, group, user) for any of the values of "event.category" (database, iam)
@taylor-swanson

Copy link
Copy Markdown
Contributor Author

I stopped watching the tests too early, running this on v8.8.2 I see this:

FAILURE DETAILS:
mysql_enterprise/audit logfile:
[0] parsing field value failed: field "event.type" value "connection" is not one of the expected values (access, change, info, error) for any of the values of "event.category" (database)
[1] parsing field value failed: field "event.type" value "connection" is not one of the expected values (access, change, info, error, admin, creation, deletion, group, user) for any of the values of "event.category" (database, iam)

That is... bad. Our tests aren't catching this. I'll take a look at it.

@efd6

efd6 commented Jul 30, 2023

Copy link
Copy Markdown
Contributor

The kibana.version is "^7.17.0 || ^8.0.0" so the tests are being run on 7.17.0, which doesn't have any concerns about these field value constraints.

@taylor-swanson

Copy link
Copy Markdown
Contributor Author

The kibana.version is "^7.17.0 || ^8.0.0" so the tests are being run on 7.17.0, which doesn't have any concerns about these field value constraints.

That makes sense for CI, but it's also passing for me locally on 8.9.0 and I'm not sure why. Looking at the expected files, it should be failing.

@taylor-swanson
taylor-swanson merged commit e5f7d18 into elastic:main Aug 1, 2023
@taylor-swanson
taylor-swanson deleted the pkg-spec-mysql_enterprise branch August 1, 2023 12:42
@elasticmachine

Copy link
Copy Markdown

Package mysql_enterprise - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=mysql_enterprise

@andrewkroh andrewkroh added the Integration:mysql_enterprise MySQL Enterprise (Audit Logs) label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
- Update package spec to 2.9.0.
- Ensure that event.category and event.type are set properly.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=v8.8.0 -format-version=2.9.0 packages/mysql_enterprise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:mysql_enterprise MySQL Enterprise (Audit Logs)

4 participants