Skip to content

Update Kibana integration to collect task manager HTTP metrics - #7205

Merged
ymao1 merged 10 commits into
elastic:mainfrom
ymao1:http-metrics
Aug 28, 2023
Merged

Update Kibana integration to collect task manager HTTP metrics#7205
ymao1 merged 10 commits into
elastic:mainfrom
ymao1:http-metrics

Conversation

@ymao1

@ymao1 ymao1 commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the Kibana HTTP integration to collect task manager SLI metrics from the Kibana API endpoint added in this PR.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • Run the stack using elastic-package: elastic-package stack up --version=8.10.0-SNAPSHOT -v -d
  • Build the package:
    • cd integrations/packages/kibana
    • elastic-package build
  • Deploy the package: elastic-package stack up -v -d --services package-registry
  • Navigate to https://localhost:5601/app/integrations/browse
  • Select and add the Kibana integration
  • Verify you see the new HTTP metrics > Kibana task manager metrics integration
  • Configure the integration for host https://kibana:5601 and username/password elastic:changeme
  • Verify you see a datastream for metrics-kibana.task_manager_metrics-default
  • Verify you see data in the datastream (GET metrics-kibana.task_manager_metrics-default/_search) with the kibana.task_manager_metrics.metrics field populated

Related issues

Screenshots

@elasticmachine

elasticmachine commented Aug 1, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-28T12:44:44.081+0000

  • Duration: 33 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 1
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ymao1 ymao1 changed the title Http metrics Aug 1, 2023
@elasticmachine

elasticmachine commented Aug 1, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (4/4) 💚 8.333
Classes 100.0% (4/4) 💚 8.333
Methods 95.556% (43/45) 👍 10.399
Lines 87.234% (82/94) 👎 -5.225
Conditionals 100.0% (0/0) 💚
@ymao1 ymao1 self-assigned this Aug 23, 2023
@ymao1
ymao1 marked this pull request as ready for review August 23, 2023 18:06
@ymao1
ymao1 requested a review from a team as a code owner August 23, 2023 18:06
Comment thread packages/kibana/changelog.yml Outdated
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.3.7"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we add feature can we bump minor instead ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So 2.4.0?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 2.4.0 in this commit: 8e97013

@klacabane klacabane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
ymao1 merged commit 29e47b8 into elastic:main Aug 28, 2023
@ymao1
ymao1 deleted the http-metrics branch August 28, 2023 13:21
@elasticmachine

Copy link
Copy Markdown

Package kibana - 2.4.0 containing this change is available at https://epr.elastic.co/search?package=kibana

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…ic#7205)

* Update kibana integration to collect task manager metrics API data

* Using histogram field

* Updating kibana version to 8.10

* cleanup

* build

* trying dynamic field

* trying dynamic field

* Bumping minor version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants