Skip to content

[Azure][container_service] Add missing azure dimensions to the kube_pod_status_phase and kube_pod_status_ready metrics - #7245

Merged
tetianakravchenko merged 2 commits into
elastic:mainfrom
tetianakravchenko:azure-container-service-missing-dimensions
Aug 4, 2023
Merged

[Azure][container_service] Add missing azure dimensions to the kube_pod_status_phase and kube_pod_status_ready metrics#7245
tetianakravchenko merged 2 commits into
elastic:mainfrom
tetianakravchenko:azure-container-service-missing-dimensions

Conversation

@tetianakravchenko

@tetianakravchenko tetianakravchenko commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Add missing dimensions to the kube_pod_status_phase and kube_pod_status_ready metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@tetianakravchenko
Add missing azure dimensions to the kube_pod_status_phase and kube_po…
38404ee 
…d_status_ready metrics

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
tetianakravchenko requested a review from a team as a code owner August 3, 2023 14:46
@tetianakravchenko
tetianakravchenko requested a review from zmoog August 3, 2023 14:46
@tetianakravchenko tetianakravchenko mentioned this pull request Aug 3, 2023
Merged
4 tasks
@elasticmachine

elasticmachine commented Aug 3, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-04T10:50:34.441+0000

  • Duration: 14 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Aug 3, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👍 9.919
Lines 100.0% (21/21) 💚 0.137
Conditionals 100.0% (0/0) 💚
zmoog
zmoog approved these changes Aug 4, 2023
View reviewed changes

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@tetianakravchenko
tetianakravchenko merged commit 29dd721 into elastic:main Aug 4, 2023
@tetianakravchenko
tetianakravchenko deleted the azure-container-service-missing-dimensions branch August 4, 2023 11:06
@elasticmachine

elasticmachine commented Aug 4, 2023

Copy link
Copy Markdown

Package azure_metrics - 1.0.18 containing this change is available at https://epr.elastic.co/search?package=azure_metrics
@tetianakravchenko tetianakravchenko mentioned this pull request Aug 9, 2023
Closed
31 tasks
@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@tetianakravchenko
[Azure][container_service] Add missing azure dimensions to the kube_p…
ebd7cbf 
…od_status_phase and kube_pod_status_ready metrics (elastic#7245)

* Add missing azure dimensions to the kube_pod_status_phase and kube_pod_status_ready metrics

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix pr url

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:azure_metrics Azure Resource Metrics

4 participants

@tetianakravchenko @elasticmachine @zmoog @andrewkroh