Skip to content

[M365 Defender] Fix fingerprint processor fields for log datastream - #7255

Merged
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:m365_defender_logs_fingerprint
Aug 8, 2023
Merged

[M365 Defender] Fix fingerprint processor fields for log datastream #7255
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:m365_defender_logs_fingerprint

Conversation

@kcreddy

@kcreddy kcreddy commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Current fingerprint processor fields are not enough to maintain uniqueness. Updated the fields inside the fingerprint processor.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@kcreddy kcreddy changed the title [M365 Defender] Fix fingerprint processor fields Aug 4, 2023
@elasticmachine

elasticmachine commented Aug 4, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-08T08:02:22.426+0000

  • Duration: 15 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Aug 4, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (7/7) 💚 3.392
Classes 100.0% (7/7) 💚 3.392
Methods 87.952% (73/83) 👎 -3.865
Lines 90.774% (4713/5192) 👍 2.53
Conditionals 100.0% (0/0) 💚
@kcreddy
kcreddy marked this pull request as ready for review August 4, 2023 11:56
@kcreddy
kcreddy requested a review from a team as a code owner August 4, 2023 11:56
@kcreddy kcreddy added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:m365_defender Microsoft Defender XDR labels Aug 4, 2023
@elasticmachine

elasticmachine commented Aug 4, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
bhapas
bhapas reviewed Aug 7, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add assert.hit_count in system tests to make sure the number of documents ingested is always the same and for some reason there are no duplicates ingested.

Also, if a log entry with duplicated fingerprint does not exist, Can we add one to make sure it is dropped.
@kcreddy
kcreddy requested a review from bhapas August 8, 2023 08:20
bhapas
bhapas approved these changes Aug 8, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kcreddy
kcreddy merged commit f741250 into elastic:main Aug 8, 2023
@kcreddy
kcreddy deleted the m365_defender_logs_fingerprint branch August 8, 2023 09:34
@elasticmachine

elasticmachine commented Aug 8, 2023

Copy link
Copy Markdown

Package m365_defender - 1.17.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender
@elasticmachine

elasticmachine commented Sep 6, 2023

Copy link
Copy Markdown

Package m365_defender - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=m365_defender
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@kcreddy
[M365 Defender] Fix fingerprint processor fields for log datastream (e…
c2b818d 
…lastic#7255)

* update fingerprint processor

* update changelog entry

* Add test assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:m365_defender Microsoft Defender XDR

3 participants

@kcreddy @elasticmachine @bhapas