[GCP] Fix check on gcp.audit.authorization_info[].granted - #7308
Merged
Conversation
When `gcp.audit.authorization_info[]` objects do not contain the `granted` attribute, the `if` statement fails. The updated `if` checks for null values and uses the `granted == true` syntax to avoid another error when there the `==` operator is not used: ``` Cannot invoke "Object.getClass()" because "value" is null ```
🌐 Coverage report
|
zmoog
marked this pull request as ready for review
August 8, 2023 15:22
zmoog
force-pushed
the
zmoog/gcp-audit-logs
branch
from
August 8, 2023 15:22
6b11263 to
ed458c3
Compare
|
Package gcp - 2.25.1 containing this change is available at https://epr.elastic.co/search?package=gcp |
4 tasks
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
* Fix check on gcp.audit.authorization_info[].granted When `gcp.audit.authorization_info[]` objects do not contain the `granted` attribute, the `if` statement fails. The updated `if` checks for null values and uses the `granted == true` syntax to avoid another error when there the `==` operator is not used: ``` Cannot invoke "Object.getClass()" because "value" is null ``` * Use `override` to avoid using a script expression * Add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
gcp.audit.authorization_info[]objects do not contain thegrantedattribute, theifstatement fails.This PR updates the expression in the
ifto check for null values and uses thegranted == truesyntax to avoid another error when there the
==operator is not used.The following error occurs with
... ctx?.gcp?.audit?.authorization_info[0]?.grantedandgrantedis null.Checklist
changelog.ymlfile.How to test this PR locally
And then run the pipeline tests using the new
data_stream/audit/_dev/test/pipeline/test-sdh-3695.logtest case:Related issues