Skip to content

[Cloud Security] Backport v1.2 PR 7185 - #7355

Closed
mitodrummer wants to merge 3 commits into
elastic:backport-cloud_security_posture-1.2from
mitodrummer:backport_v1.2_PR_7185
Closed

[Cloud Security] Backport v1.2 PR 7185#7355
mitodrummer wants to merge 3 commits into
elastic:backport-cloud_security_posture-1.2from
mitodrummer:backport_v1.2_PR_7185

Conversation

@mitodrummer

@mitodrummer mitodrummer commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds backwards compatibility for the migration from cluster_id -> orchestrator.cluster.id ECS field for cloudbeat agents pre 8.8.0

Original PR: #7185

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@mitodrummer mitodrummer added enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Integration:cloud_security_posture Security Posture Management labels Aug 10, 2023
@mitodrummer
mitodrummer requested a review from a team as a code owner August 10, 2023 21:32
@mitodrummer
mitodrummer requested a review from kfirpeled August 10, 2023 21:32
@elasticmachine

elasticmachine commented Aug 10, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-14T20:41:32.576+0000

  • Duration: 15 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (1/4) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
@mitodrummer

Copy link
Copy Markdown
Contributor Author

@kfirpeled This was the first backport version which the latest elastic-package binary was able to still build. Do you know how to check which version of elastic-package is needed for each backport branch?

Seems as if 1.2 and below doesn't have a buildkite file either, but I assume that is a new system and jenkins will still publish what we need?

@kfirpeled

Copy link
Copy Markdown
Contributor

@kfirpeled This was the first backport version which the latest elastic-package binary was able to still build. Do you know how to check which version of elastic-package is needed for each backport branch?

Seems as if 1.2 and below doesn't have a buildkite file either, but I assume that is a new system and jenkins will still publish what we need?

That is a great question, I'm not sure what should be done here to support this backport
We definitely should explore why it was failed and fix it for future backportings

@kfirpeled

Copy link
Copy Markdown
Contributor

we might need to rebase this branch with main

@kfirpeled

Copy link
Copy Markdown
Contributor

We've decided for now not to support more than two adjacent minor versions
Closing this PR

@kfirpeled kfirpeled closed this Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

3 participants