Skip to content

[GCP] [CloudSQL] Fix metrics and fields - #7367

Merged
8 commits merged into
mainfrom
unknown repository
Sep 8, 2023
Merged

[GCP] [CloudSQL] Fix metrics and fields#7367
8 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 13, 2023

Copy link
Copy Markdown

What does this PR do?

Some CloudSQL metrics were deprecated or are alpha/beta, I removed all those metrics and fields. A few fields were also added with the wrong field type.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@ghost ghost self-assigned this Aug 13, 2023
@elasticmachine

elasticmachine commented Aug 13, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-08T19:14:32.018+0000

  • Duration: 18 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Aug 13, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 87.826% (101/115) 👍 12.069
Lines 96.0% (1464/1525) 👎 -4.0
Conditionals 100.0% (0/0) 💚
@ghost
ghost marked this pull request as ready for review August 13, 2023 20:01
@ghost
ghost requested review from a team as code owners August 13, 2023 20:01
@ghost
ghost merged commit 352b396 into elastic:main Sep 8, 2023
@elasticmachine

elasticmachine commented Sep 8, 2023

Copy link
Copy Markdown

Package gcp - 2.29.0 containing this change is available at https://epr.elastic.co/search?package=gcp
@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Gabriel Pop
[GCP] [CloudSQL] Fix metrics and fields (elastic#7367)
257379a 
* fix mysql

* fix postgresql

* fix sqlserver

* update docs

* bump package version

* update docs
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform

4 participants

@elasticmachine @zmoog @andrewkroh @mrg-elastic