[Azure] [monitor] Add dimension and metric_type metadata to the monitor datastream - #7473
Merged
tetianakravchenko merged 5 commits intoAug 30, 2023
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
tetianakravchenko
changed the title
31 tasks
zmoog
requested changes
Aug 23, 2023
zmoog
left a comment
zmoog
left a comment
Contributor
There was a problem hiding this comment.
I suggest adding event.kind: pipeline_error in case of pipeline failure, I see this behavior adopted more and more.
We should consider using error.message as an array, as it has become increasingly common but optional.
Comment on lines
+8
to
+11
| on_failure: | ||
| - set: | ||
| field: error.message | ||
| value: '{{ _ingest.on_failure_message }}' |
Contributor
There was a problem hiding this comment.
What about also setting event.kind?
Here's an example of the current trend: https://github.com/elastic/integrations/pull/7043/files#diff-ff596a529bb3558054ae525d4e233a54a30963b2ac998fc37eeaa1ed29d66474
Suggested change
| on_failure: | |
| - set: | |
| field: error.message | |
| value: '{{ _ingest.on_failure_message }}' | |
| on_failure: | |
| - set: | |
| field: event.kind | |
| value: pipeline_error | |
| - set: | |
| field: error.message | |
| value: '{{ _ingest.on_failure_message }}' |
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
zmoog
approved these changes
Aug 28, 2023
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
ghost
approved these changes
Aug 30, 2023
|
Package azure_metrics - 1.0.34 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
…or datastream (elastic#7473) * Add dimension and metric_type metadata to the monitor datastream Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * fix pr url in cahangelog; add ingest pipeline Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * address pr review Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add dimension and metric_type metadata to the monitor datastream
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots