Skip to content

[problemchild] Ensure event.kind is correctly set for pipeline errors - #7501

Merged
susan-shu-c merged 4 commits into
elastic:mainfrom
MakoWish:6582-problemchild
Aug 29, 2023
Merged

[problemchild] Ensure event.kind is correctly set for pipeline errors#7501
susan-shu-c merged 4 commits into
elastic:mainfrom
MakoWish:6582-problemchild

Conversation

@MakoWish

@MakoWish MakoWish commented Aug 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Modify problemchild integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots
@MakoWish
MakoWish marked this pull request as ready for review August 22, 2023 22:36
@MakoWish
MakoWish requested review from a team as code owners August 22, 2023 22:36
@elasticmachine

elasticmachine commented Aug 22, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-24T19:08:06.252+0000

  • Duration: 16 min 30 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
peteharverson
peteharverson approved these changes Aug 24, 2023
View reviewed changes

@peteharverson peteharverson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - ml-ui are down as CODEOWNERS of this package. No specific ML changes here but LGTM to clear the ml-ui approval.
@MakoWish

MakoWish commented Aug 24, 2023

Copy link
Copy Markdown
Contributor Author

Would someone mind kicking off a /test? I don't have permissions.
@susan-shu-c

susan-shu-c commented Aug 24, 2023

Copy link
Copy Markdown
Member

/test
@MakoWish

MakoWish commented Aug 28, 2023

Copy link
Copy Markdown
Contributor Author

I don't have permissions to merge. Would someone be so kind? :-)
@susan-shu-c
susan-shu-c merged commit 1c48a89 into elastic:main Aug 29, 2023
@susan-shu-c

susan-shu-c commented Aug 29, 2023

Copy link
Copy Markdown
Member

Just saw this, merged!
@elasticmachine

elasticmachine commented Aug 29, 2023

Copy link
Copy Markdown

Package problemchild - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=problemchild
@MakoWish
MakoWish deleted the 6582-problemchild branch August 29, 2023 17:41
@andrewkroh andrewkroh added the Integration:problemchild Living off the Land Attack Detection label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@MakoWish
[problemchild] Ensure event.kind is correctly set for pipeline errors (…
fa6563a 
…elastic#7501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:problemchild Living off the Land Attack Detection

5 participants

@MakoWish @elasticmachine @susan-shu-c @peteharverson @andrewkroh