Skip to content

[TI_OTX] Add IOC expiration support with new datastream - #7530

Merged
kcreddy merged 24 commits into
elastic:mainfrom
kcreddy:otx_ioc_expiry
Oct 12, 2023
Merged

[TI_OTX] Add IOC expiration support with new datastream#7530
kcreddy merged 24 commits into
elastic:mainfrom
kcreddy:otx_ioc_expiry

Conversation

@kcreddy

@kcreddy kcreddy commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Adds new datastream pulses_subscribed using CEL input with IOC expiration support.
  • Adds DLM
  • Add owner.type to package manifest.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Notes

Related issues

Screenshots

Screenshot 2023-09-26 at 10 33 16 AM Screenshot 2023-09-26 at 10 32 18 AM Screenshot 2023-09-26 at 10 33 42 AM
@elasticmachine

elasticmachine commented Aug 24, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T06:14:18.244+0000

  • Duration: 16 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Aug 24, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 95.833% (23/24) 👍 29.167
Lines 69.324% (287/414) 👎 -30.676
Conditionals 100.0% (0/0) 💚
@kcreddy kcreddy self-assigned this Aug 24, 2023
@kcreddy kcreddy added enhancement New feature or request Integration:ti_otx AlienVault OTX labels Aug 24, 2023
@kcreddy
kcreddy marked this pull request as ready for review September 13, 2023 09:24
@kcreddy
kcreddy requested a review from a team as a code owner September 13, 2023 09:24
Comment thread packages/ti_otx/_dev/build/docs/README.md Outdated
Comment thread packages/ti_otx/_dev/build/docs/README.md Outdated

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add some screenshots of the new data_stream

Comment thread packages/ti_otx/_dev/build/docs/README.md Outdated
Comment thread packages/ti_otx/_dev/build/docs/README.md Outdated
Comment thread packages/ti_otx/data_stream/pulses_subscribed/agent/stream/cel.yml.hbs Outdated
Comment thread packages/ti_otx/data_stream/pulses_subscribed/agent/stream/cel.yml.hbs Outdated
Comment thread packages/ti_otx/data_stream/pulses_subscribed/fields/agent.yml

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for @bhapas.

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy
kcreddy requested a review from efd6 October 11, 2023 15:37
@kcreddy
kcreddy merged commit 3baf029 into elastic:main Oct 12, 2023
@elasticmachine

Copy link
Copy Markdown

Package ti_otx - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=ti_otx

1 similar comment
@elasticmachine

Copy link
Copy Markdown

Package ti_otx - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=ti_otx

@kcreddy
kcreddy deleted the otx_ioc_expiry branch February 7, 2025 08:37
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Adds new datastream pulses_subscribed using CEL input with IOC expiration support.

* Adds DLM for supporting Serverless projects.

* Add owner.type to package manifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:ti_otx AlienVault OTX

4 participants