Skip to content

Enable static test runner - #754

Merged
mtojek merged 20 commits into
elastic:masterfrom
mtojek:fix-static-events
Mar 2, 2021
Merged

Enable static test runner#754
mtojek merged 20 commits into
elastic:masterfrom
mtojek:fix-static-events

Conversation

@mtojek

@mtojek mtojek commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR enables static test runner which can validate sample_event.json files.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@mtojek mtojek self-assigned this Mar 1, 2021
@mtojek
mtojek force-pushed the fix-static-events branch from 1ebb849 to 779528b Compare March 1, 2021 16:15
@elasticmachine

elasticmachine commented Mar 1, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #754 updated

  • Start Time: 2021-03-02T16:09:38.731+0000

  • Duration: 40 min 13 sec

  • Commit: 2cfc1a7

Test stats 🧪

Test Results
Failed 0
Passed 1842
Skipped 3
Total 1845

Trends 🧪

Image of Build Times

Image of Tests

@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 1, 2021
@mtojek
mtojek requested a review from ycombinator March 2, 2021 11:09
@mtojek
mtojek marked this pull request as ready for review March 2, 2021 11:09
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@mtojek

mtojek commented Mar 2, 2021

Copy link
Copy Markdown
Contributor Author

jenkins run the tests please

1 similar comment
@mtojek

mtojek commented Mar 2, 2021

Copy link
Copy Markdown
Contributor Author

jenkins run the tests please

Comment thread packages/aws/manifest.yml
name: aws
title: AWS
version: 0.4.0
version: 0.4.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump up the version?

@ycombinator ycombinator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in packages LGTM, except I'm wondering if we want to bump up the versions in the package's manifest.yml files for these changes. They could go out with other changes in the future, no?

@mtojek

mtojek commented Mar 2, 2021

Copy link
Copy Markdown
Contributor Author

Changes in packages LGTM, except I'm wondering if we want to bump up the versions in the package's manifest.yml files for these changes. They could go out with other changes in the future, no?

I would say that this PR cleans up the package content which is shown to the customer (sample events) and we don't have any publishing timeline for these packages. If you don't mind, I would be for releasing them due to consistency reasons (all sample events are looking the same).

@ycombinator

Copy link
Copy Markdown
Contributor

I would be for releasing them due to consistency reasons (all sample events are looking the same).

Ah, okay, that makes sense then. ++ to upversioning.

@ycombinator ycombinator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek
mtojek merged commit 8770467 into elastic:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Integrations Label for the Integrations team

4 participants