Skip to content

Refactoring GCP credentials -Fix continuation - #7546

Merged
animehart merged 2 commits into
elastic:mainfrom
animehart:ricky-refactor-fix-gcp
Aug 25, 2023
Merged

Refactoring GCP credentials -Fix continuation#7546
animehart merged 2 commits into
elastic:mainfrom
animehart:ricky-refactor-fix-gcp

Conversation

@animehart

@animehart animehart commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

On my previous PR (#7537) I forgot to include the changelog and manifest yml change
as such It didnt trigger the build to see my changes

@animehart
animehart requested a review from a team as a code owner August 25, 2023 21:37
Comment thread packages/cloud_security_posture/changelog.yml Outdated
Comment thread packages/cloud_security_posture/changelog.yml Outdated

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine

elasticmachine commented Aug 25, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-25T21:46:25.699+0000

  • Duration: 16 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
@animehart
animehart merged commit 08b81d3 into elastic:main Aug 25, 2023
@elasticmachine

Copy link
Copy Markdown

Package cloud_security_posture - 1.5.2-preview2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@oren-zohar

Copy link
Copy Markdown
Contributor

@animehart was it tested with preview? Can we publish it in production?

@elasticmachine

Copy link
Copy Markdown

Package cloud_security_posture - 1.5.2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Forgot to add the changelog from my PR before

* pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:cloud_security_posture Security Posture Management

6 participants