Skip to content

[GCP] Set metric type for Cloud Run, Compute, Dataproc and Firestore data streams - #7560

Merged
constanca-m merged 3 commits into
elastic:mainfrom
constanca-m:set2-gcp-add-metric-type
Aug 29, 2023
Merged

[GCP] Set metric type for Cloud Run, Compute, Dataproc and Firestore data streams#7560
constanca-m merged 3 commits into
elastic:mainfrom
constanca-m:set2-gcp-add-metric-type

Conversation

@constanca-m

@constanca-m constanca-m commented Aug 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Set metric type for the following data streams:

  • Cloud Run: metric type documentation can be found here
  • Compute: metric type documentation can be found here
  • Dataproc: metric type documentation can be found here
  • Firestore: metric type documentation can be found here

Important note: all delta metrics are gauge metrics. Related issue for that: elastic/elasticsearch#98171.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #7555
@constanca-m
Set metric type.
35287de 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 28, 2023
@constanca-m
constanca-m requested a review from a team as a code owner August 28, 2023 09:21
@constanca-m constanca-m self-assigned this Aug 28, 2023
@constanca-m
constanca-m requested a review from a team as a code owner August 28, 2023 09:21
@constanca-m
Update changelog.
2e348db 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m mentioned this pull request Aug 28, 2023
Closed
4 tasks
@elasticmachine

elasticmachine commented Aug 28, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-29T09:32:24.462+0000

  • Duration: 18 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Aug 28, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 87.826% (101/115) 👎 -12.174
Lines 96.0% (1464/1525) 👍 2.142
Conditionals 100.0% (0/0) 💚
endorama
endorama approved these changes Aug 29, 2023
View reviewed changes

@endorama endorama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from manifest/changelog update needed looks good to me!
@constanca-m
constanca-m merged commit d7736da into elastic:main Aug 29, 2023
@constanca-m
constanca-m deleted the set2-gcp-add-metric-type branch August 29, 2023 09:56
@elasticmachine

elasticmachine commented Aug 29, 2023

Copy link
Copy Markdown

Package gcp - 2.28.3 containing this change is available at https://epr.elastic.co/search?package=gcp
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@constanca-m
[GCP] Set metric type for Cloud Run, Compute, Dataproc and Firestore …
927b5f1 
…data streams (elastic#7560)

* Set metric type.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

* Update changelog.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

---------

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

3 participants

@constanca-m @elasticmachine @endorama