[azure_application_insights] [app_insights] Add dimensions and metric_type for metrics - #7610
[azure_application_insights] [app_insights] Add dimensions and metric_type for metrics#76106 commits merged into
Conversation
ghost
self-assigned this
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
ghost
mentioned this pull request
| dimension: true | ||
| description: | | ||
| Autogenerated ID representing the fingerprint of the azure.dimensions object | ||
| - name: metrics.*.* |
There was a problem hiding this comment.
where metrics are actually stored? in this field or in azure.app_insights.metrics.*.* ? I think one of them is redundant and should be removed
There was a problem hiding this comment.
According to some app insights metrics I collected in June, the app insight metricset stores metrics in the azure.metrics.* fields:
There was a problem hiding this comment.
@gpop63, did you get metrics in these fields as well in your recent tests?
There was a problem hiding this comment.
@zmoog Yeah, the metrics are stored in azure.metrics so the metrics from fields.yml could be removed.
There was a problem hiding this comment.
Seems like metrics collected from azure.monitor also store fields under azure.metrics. Will that be a problem?
There was a problem hiding this comment.
Uhm, this should be okay. All metrics in the azure.monitor field seem fine.
zmoog
left a comment
zmoog
left a comment
There was a problem hiding this comment.
We should double-check in which fields the metricset is storing metrics.
ghost
mentioned this pull request
| @@ -1,3 +1,8 @@ | |||
| - version: "1.2.0" | |||
|
Package azure_application_insights - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=azure_application_insights |
andrewkroh
added
the
Integration:azure_application_insights
…_type for metrics (elastic#7610) * add dimensions * bump package version * fix pr id * bump kibana version * remove duplicated metrics field * change version to 1.1.0
6 participants
What does this PR do?
Dimensions added:
Added an ingest pipeline to create a fingerprint of the
azure.dimensionsfield.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots