zeek: ensure fields are not HTML escaped, and fix event.type value for sip - #7640
Merged
Conversation
efd6
added
bug
…r sip Only use triple stache template snippets to ensure that text is not multiply escaped. Also remove all redundant null-safe operators on ctx. Assigning "error" to event.type is removed in the sip data stream as this is not a valid value for event.category: network.
87 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
efd6
marked this pull request as ready for review
September 4, 2023 00:31
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Package zeek - 2.14.1 containing this change is available at https://epr.elastic.co/search?package=zeek |
1 similar comment
|
Package zeek - 2.14.1 containing this change is available at https://epr.elastic.co/search?package=zeek |
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
…r sip (elastic#7640) Only use triple stache template snippets to ensure that text is not multiply escaped. Also remove all redundant null-safe operators on ctx. Assigning "error" to event.type is removed in the sip data stream as this is not a valid value for event.category: network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Only use triple stache template snippets to ensure that text is not multiply escaped. Also remove all redundant null-safe operators on ctx.
Assigning "error" to event.type is removed in the sip data stream as this is not a valid value for event.category: network.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots