Skip to content

netflow,network_traffic,suricata: use dynamic field definitions - #7657

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:7273-importmappings
Sep 6, 2023
Merged

netflow,network_traffic,suricata: use dynamic field definitions#7657
efd6 merged 1 commit into
elastic:mainfrom
efd6:7273-importmappings

Conversation

@efd6

@efd6 efd6 commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

See title.

This is a counter proposal for #7271, #7273 and #7275.

/cc @MakoWish

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Sep 5, 2023
@efd6
efd6 force-pushed the 7273-importmappings branch from 10b26d0 to 3dbc054 Compare September 5, 2023 03:25
@elasticmachine

elasticmachine commented Sep 5, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-05T03:25:53.224+0000

  • Duration: 67 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 182
Skipped 0
Total 182

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Sep 5, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 99.099% (110/111) 👍 6.64
Lines 94.81% (1096/1156) 👍 3.308
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review September 5, 2023 04:33
@efd6
efd6 requested a review from a team as a code owner September 5, 2023 04:33
@elasticmachine

elasticmachine commented Sep 5, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kcreddy
kcreddy approved these changes Sep 6, 2023
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
@efd6
efd6 merged commit 27558a4 into elastic:main Sep 6, 2023
@elasticmachine

elasticmachine commented Sep 6, 2023

Copy link
Copy Markdown

Package netflow - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=netflow
@elasticmachine

elasticmachine commented Sep 6, 2023

Copy link
Copy Markdown

Package network_traffic - 1.22.0 containing this change is available at https://epr.elastic.co/search?package=network_traffic
@elasticmachine

elasticmachine commented Sep 6, 2023

Copy link
Copy Markdown

Package suricata - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=suricata
@vinit-chauhan vinit-chauhan mentioned this pull request Sep 8, 2023
Closed
4 tasks
@efd6
efd6 deleted the 7273-importmappings branch February 5, 2025 22:08
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
netflow,network_traffic,suricata: use dynamic field definitions (elas…
08ebbb2 
…tic#7657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:netflow NetFlow Records Integration:network_traffic Network Packet Capture Integration:suricata Suricata

3 participants

@efd6 @elasticmachine @kcreddy