[awsfirehose] remove redudant .logs suffix from dataset name - #7670
Merged
Conversation
felixbarny
approved these changes
Sep 6, 2023
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Contributor
Author
|
closing this due to technical limitation and uncertainty around whether or not this is the right thing to do. the |
ruflin
added a commit
to ruflin/elastic-package
that referenced
this pull request
Sep 8, 2023
The dataset value in the manifest.yml file can be overwritten to allow dataset names which are not `{package}.{dirName}`. One example of this can be found here: elastic/integrations#7670 This is already in use today and is used by some packages. Fleet installs all the assets as expected.
When working on elastic/integrations#7670, CI is failing. The reason is that the pipeline check did not take the custom dataset config into account. The reason why this didn't show up earlier is because the check for the template already has a similar condition in place. Likely all previous packages that used this feature did only have templates and no pipelines.
Contributor
|
I have a fix for this opened here: elastic/elastic-package#1437 |
zmoog
approved these changes
Sep 8, 2023
ruflin
added a commit
to elastic/elastic-package
that referenced
this pull request
Sep 11, 2023
The dataset value in the manifest.yml file can be overwritten to allow dataset names which are not `{package}.{dirName}`. One example of this can be found here: elastic/integrations#7670 This is already in use today and is used by some packages. Fleet installs all the assets as expected.
When working on elastic/integrations#7670, CI is failing. The reason is that the pipeline check did not take the custom dataset config into account. The reason why this didn't show up earlier is because the check for the template already has a similar condition in place. Likely all previous packages that used this feature did only have templates and no pipelines.
Contributor
|
@tommyers-elastic elastic/elastic-package#1437 has landed. To get this PR green, a new elastic-package release is needed. Can you and team help to get this over the line? |
Contributor
|
The newest version of elastic-package was just realised with the fix in places. Lets rerun CI on this PR. |
tommyers-elastic
force-pushed
the
change-firehose-logs-dataset-name
branch
from
September 13, 2023 15:16
280c9e4 to
2e13cf3
Compare
|
/test |
kaiyan-sheng
left a comment
kaiyan-sheng
left a comment
There was a problem hiding this comment.
https://github.com/elastic/integrations/blob/main/packages/awsfirehose/manifest.yml#L4 needs to be updated to 0.3.0
tommyers-elastic
force-pushed
the
change-firehose-logs-dataset-name
branch
from
September 18, 2023 14:19
82c6a67 to
a85ebcd
Compare
tommyers-elastic
force-pushed
the
change-firehose-logs-dataset-name
branch
from
September 18, 2023 14:20
a85ebcd to
fadf832
Compare
This is caused by kibana 8.10.0 image was removed. |
bhapas
pushed a commit
to bhapas/elastic-package
that referenced
this pull request
Sep 21, 2023
The dataset value in the manifest.yml file can be overwritten to allow dataset names which are not `{package}.{dirName}`. One example of this can be found here: elastic/integrations#7670 This is already in use today and is used by some packages. Fleet installs all the assets as expected.
When working on elastic/integrations#7670, CI is failing. The reason is that the pipeline check did not take the custom dataset config into account. The reason why this didn't show up earlier is because the check for the template already has a similar condition in place. Likely all previous packages that used this feature did only have templates and no pipelines.
|
Package awsfirehose - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=awsfirehose |
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The dataset name is
awsfirehose.logs, but the datastreamtypeislogs. so the datastream name islogs-awsfirehose.logs-*. This PR removes this redundancy.The package is in very early tech preview - we are not worries about this being a major breaking change.