Skip to content

tenable_io: update integration based on feedback from Tenable - #7689

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:7671-tenable_io
Sep 7, 2023
Merged

tenable_io: update integration based on feedback from Tenable#7689
efd6 merged 1 commit into
elastic:mainfrom
efd6:7671-tenable_io

Conversation

@efd6

@efd6 efd6 commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • adjust collection intervals to 24 hourly
  • make plugin and scans data stream disabled by default
  • remove scanner data stream
  • adjust branding

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-09-07 at 19 04 23 Screenshot 2023-09-07 at 19 04 57
@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:tenable_io Tenable Vulnerability Management labels Sep 7, 2023
@efd6 efd6 self-assigned this Sep 7, 2023
@efd6
efd6 force-pushed the 7671-tenable_io branch 2 times, most recently from f4e0b66 to 22557a7 Compare September 7, 2023 03:47
@elasticmachine

elasticmachine commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-07T07:48:50.416+0000

  • Duration: 16 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 97.959% (48/49) 👎 -2.041
Lines 91.971% (2142/2329) 👎 -8.029
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review September 7, 2023 04:04
@efd6
efd6 requested a review from a team as a code owner September 7, 2023 04:04
@elasticmachine

elasticmachine commented Sep 7, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
bhapas
bhapas reviewed Sep 7, 2023
View reviewed changes
Comment thread packages/tenable_io/data_stream/asset/manifest.yml Outdated
Comment thread packages/tenable_io/manifest.yml Outdated
@efd6
tenable_io: update integration based on feedback from Tenable
f27f6b3 
* adjust collection intervals to 24 hourly
* make plugin and scans data stream disabled by default
* remove scanner data stream
* adjust branding
@efd6
efd6 requested a review from bhapas September 7, 2023 07:48
bhapas
bhapas approved these changes Sep 7, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you add some screenshots of the integrations UI page with the rebranding of this integration
@efd6
efd6 merged commit 0e50c3e into elastic:main Sep 7, 2023
@elasticmachine

elasticmachine commented Sep 7, 2023

Copy link
Copy Markdown

Package tenable_io - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=tenable_io
@bhapas

bhapas commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

@efd6 The first screenshot still shows lot of instances of tenable.io references? Should we not change them in documentation?
@efd6

efd6 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor Author

Browser cache. PTAL. There are remaining instances in the dashboards.
@MakoWish

MakoWish commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Why was the scanner dataset removed? I added that one.
@efd6

efd6 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor Author

This was removed because of feedback from Tenable. It is in the work list in #7671. @jamiehynds Can you comment on this?
@MakoWish

MakoWish commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Yeah, it just says "remove", but no real reasoning behind it.
@efd6
efd6 deleted the 7671-tenable_io branch February 5, 2025 22:08
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
tenable_io: update integration based on feedback from Tenable (elasti…
84ae9bd 
…c#7689)

* adjust collection intervals to 24 hourly
* make plugin and scans data stream disabled by default
* remove scanner data stream
* adjust branding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:tenable_io Tenable Vulnerability Management

4 participants

@efd6 @elasticmachine @bhapas @MakoWish