Skip to content

m365_defender: fix template snippet escaping behaviour and add event.kind for pipeline errors - #7707

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:7641-m365_defender
Sep 8, 2023
Merged

m365_defender: fix template snippet escaping behaviour and add event.kind for pipeline errors#7707
efd6 merged 1 commit into
elastic:mainfrom
efd6:7641-m365_defender

Conversation

@efd6

@efd6 efd6 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

See title.

(The majority of the work fixing template snippets in m365_defender was done in #7522, so this is just to knock it on the head).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:m365_defender Microsoft Defender XDR labels Sep 7, 2023
@efd6 efd6 self-assigned this Sep 7, 2023
@efd6
efd6 force-pushed the 7641-m365_defender branch from d9e69e9 to 5bdf0df Compare September 7, 2023 21:59
@elasticmachine

elasticmachine commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-07T21:59:25.766+0000

  • Duration: 16 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6 efd6 mentioned this pull request Sep 7, 2023
Open
87 tasks
@elasticmachine

elasticmachine commented Sep 7, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (7/7) 💚 5.556
Classes 100.0% (7/7) 💚 5.556
Methods 85.556% (77/90) 👎 -0.398
Lines 92.596% (5590/6037) 👍 6.572
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review September 7, 2023 22:56
@efd6
efd6 requested a review from a team as a code owner September 7, 2023 22:56
@elasticmachine

elasticmachine commented Sep 7, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
bhapas
bhapas approved these changes Sep 8, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6
efd6 merged commit 58978b9 into elastic:main Sep 8, 2023
@elasticmachine

elasticmachine commented Sep 8, 2023

Copy link
Copy Markdown

Package m365_defender - 2.0.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender
@efd6
efd6 deleted the 7641-m365_defender branch February 5, 2025 22:08
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
m365_defender: fix template snippet escaping behaviour and add event.…
672bf9a 
…kind for pipeline errors (elastic#7707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:m365_defender Microsoft Defender XDR

3 participants

@efd6 @elasticmachine @bhapas