Skip to content

checkpoint,github,hid_bravura_monitor: make types match - #7714

Merged
efd6 merged 3 commits into
elastic:mainfrom
efd6:7708-10-typeagree
Sep 8, 2023
Merged

checkpoint,github,hid_bravura_monitor: make types match#7714
efd6 merged 3 commits into
elastic:mainfrom
efd6:7708-10-typeagree

Conversation

@efd6

@efd6 efd6 commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Makes fields with the same name agree in type.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added bug Something isn't working, use only for issues enhancement New feature or request Team:Security-External Integrations Integration:checkpoint Check Point Integration:github GitHub Integration:hid_bravura_monitor Bravura Monitor (Partner supported) labels Sep 8, 2023
@efd6 efd6 self-assigned this Sep 8, 2023
@efd6
efd6 force-pushed the 7708-10-typeagree branch from 10f6911 to 499d5b8 Compare September 8, 2023 03:48
@elasticmachine

elasticmachine commented Sep 8, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-08T06:58:12.103+0000

  • Duration: 18 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 101
Skipped 0
Total 101

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Sep 8, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 98.131% (105/107) 👍 12.575
Lines 92.068% (2426/2635) 👎 -0.527
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review September 8, 2023 04:13
@efd6
efd6 requested a review from a team as a code owner September 8, 2023 04:13
@elasticmachine

elasticmachine commented Sep 8, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
bhapas
bhapas reviewed Sep 8, 2023
View reviewed changes
Comment thread packages/hid_bravura_monitor/changelog.yml Outdated
@efd6
efd6 force-pushed the 7708-10-typeagree branch from 499d5b8 to e816ba1 Compare September 8, 2023 06:57
@efd6
efd6 requested a review from bhapas September 8, 2023 07:13
bhapas
bhapas approved these changes Sep 8, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6
efd6 merged commit 7ead005 into elastic:main Sep 8, 2023
@elasticmachine

elasticmachine commented Sep 8, 2023

Copy link
Copy Markdown

Package checkpoint - 1.24.0 containing this change is available at https://epr.elastic.co/search?package=checkpoint
@elasticmachine

elasticmachine commented Sep 8, 2023

Copy link
Copy Markdown

Package github - 1.20.1 containing this change is available at https://epr.elastic.co/search?package=github
@elasticmachine

elasticmachine commented Sep 8, 2023

Copy link
Copy Markdown

Package hid_bravura_monitor - 1.10.1 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor
@efd6
efd6 deleted the 7708-10-typeagree branch February 5, 2025 22:08
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
checkpoint,github,hid_bravura_monitor: make types match (elastic#7714)
470a7e6 
* checkpoint: make checkpoint.subs_exp a date
* github: ensure data streams agree on type of github.repository.description
* hid_bravura_monitor: make winlog.time_created a date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues enhancement New feature or request Integration:checkpoint Check Point Integration:github GitHub Integration:hid_bravura_monitor Bravura Monitor (Partner supported)

3 participants

@efd6 @elasticmachine @bhapas