Skip to content

[O11y][Traefik] Add metric_type for health datastream - #7768

Merged
harnish-crest-data merged 8 commits into
elastic:mainfrom
chavdaharnish:traefik-health-add-metric_type
Oct 10, 2023
Merged

[O11y][Traefik] Add metric_type for health datastream#7768
harnish-crest-data merged 8 commits into
elastic:mainfrom
chavdaharnish:traefik-health-add-metric_type

Conversation

@harnish-crest-data

@harnish-crest-data harnish-crest-data commented Sep 12, 2023

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

This PR adds metric_type mapping for the fields of the health data stream.

Checklist

Screenshot

Refer: #7766
@harnish-crest-data harnish-crest-data self-assigned this Sep 12, 2023
@harnish-crest-data
harnish-crest-data marked this pull request as ready for review September 12, 2023 05:46
@harnish-crest-data
harnish-crest-data requested a review from a team as a code owner September 12, 2023 05:46
@harnish-crest-data harnish-crest-data mentioned this pull request Sep 12, 2023
Closed
6 tasks
@elasticmachine

elasticmachine commented Sep 12, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T10:53:06.567+0000

  • Duration: 19 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Sep 12, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (26/26) 💚
Lines 97.706% (213/218) 👍 2.184
Conditionals 100.0% (0/0) 💚
ritalwar
ritalwar reviewed Sep 27, 2023
View reviewed changes
Comment thread packages/traefik/changelog.yml Outdated
Comment thread packages/traefik/data_stream/health/fields/fields.yml
@harnish-crest-data
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
cca842c 
…into traefik-health-add-metric_type

Conflicts:
	packages/traefik/changelog.yml
	packages/traefik/manifest.yml
@harnish-crest-data
harnish-crest-data force-pushed the traefik-health-add-metric_type branch from 9006c8b to cca842c Compare September 28, 2023 12:48
@harnish-crest-data

harnish-crest-data commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author

/test
1 similar comment
@harnish-crest-data

harnish-crest-data commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

/test
@agithomas

agithomas commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

@harnish-elastic , please complete the peer review.
@agithomas

agithomas commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

@ritalwar , are you good to approve the PR ?
milan-elastic
milan-elastic approved these changes Oct 6, 2023
View reviewed changes

@milan-elastic milan-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@ritalwar

ritalwar commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

In the screenshot of Discover view, I notice gauge and counter icons associated with other fields, but for "response.status_codes," the icon doesn't match the specified type, which is "counter." Is the metric type successfully applied in this case?
@harnish-crest-data

harnish-crest-data commented Oct 6, 2023

Copy link
Copy Markdown
Contributor Author

In the screenshot of Discover view, I notice gauge and counter icons associated with other fields, but for "response.status_codes," the icon doesn't match the specified type, which is "counter." Is the metric type successfully applied in this case?

Updated screenshot, thanks!
ritalwar
ritalwar approved these changes Oct 6, 2023
View reviewed changes

@ritalwar ritalwar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
agithomas
agithomas reviewed Oct 9, 2023
View reviewed changes
Comment thread packages/traefik/data_stream/health/fields/fields.yml Outdated
agithomas
agithomas approved these changes Oct 10, 2023
View reviewed changes

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@harnish-crest-data
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
616baba 
…into traefik-health-add-metric_type

Conflicts:
	packages/traefik/changelog.yml
	packages/traefik/docs/README.md
	packages/traefik/manifest.yml
@harnish-crest-data
harnish-crest-data merged commit 913c482 into elastic:main Oct 10, 2023
@elasticmachine

elasticmachine commented Oct 10, 2023

Copy link
Copy Markdown

Package traefik - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=traefik
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@harnish-crest-data
[O11y][Traefik] Add metric_type for health datastream (elastic#7768)
8d48682 
* add metric_type for health data streams

* update changelog.yml

* address review comments

* update kibana version

* update kibana version

* update format for metric_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:traefik Traefik

5 participants

@harnish-crest-data @elasticmachine @agithomas @ritalwar @milan-elastic