Skip to content

Add routing rules for WAF logs based on log format - #7836

Merged
kaiyan-sheng merged 5 commits into
elastic:mainfrom
kaiyan-sheng:waf_logs
Sep 21, 2023
Merged

Add routing rules for WAF logs based on log format#7836
kaiyan-sheng merged 5 commits into
elastic:mainfrom
kaiyan-sheng:waf_logs

Conversation

@kaiyan-sheng

@kaiyan-sheng kaiyan-sheng commented Sep 14, 2023

Copy link
Copy Markdown

What does this PR do?

This PR is to enhance routing rules for WAF logs based its log format instead of firehose stream name and cloudwatch log group name. This way when WAF logs are sent to S3 bucket -> lambda -> firehose, our awsfirehose integration will still be able to route it correctly.

This PR also removes all namespace in routing rules since we are using the default, no need to specify it. (will make this a separate change, this is causing error when running elastic-package test -v --report-format xUnit --report-output file --test-coverage command)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@kaiyan-sheng
kaiyan-sheng marked this pull request as ready for review September 14, 2023 22:31
@kaiyan-sheng
kaiyan-sheng requested a review from a team as a code owner September 14, 2023 22:31
@elasticmachine

elasticmachine commented Sep 14, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-20T22:10:46.874+0000

  • Duration: 15 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Comment thread packages/awsfirehose/changelog.yml Outdated
Comment thread packages/awsfirehose/data_stream/logs/routing_rules.yml Outdated
@kaiyan-sheng kaiyan-sheng changed the title Add routing rules for WAF logs based on log format and remove namespace Sep 20, 2023
@kaiyan-sheng kaiyan-sheng self-assigned this Sep 20, 2023
@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 8.333
Classes 100.0% (1/1) 💚 8.333
Methods 60.0% (3/5) 👎 -25.156
Lines 100.0% (79/79) 💚 8.45
Conditionals 100.0% (0/0) 💚
@kaiyan-sheng
kaiyan-sheng merged commit 05f32f4 into elastic:main Sep 21, 2023
@kaiyan-sheng
kaiyan-sheng deleted the waf_logs branch September 21, 2023 15:03
@elasticmachine

Copy link
Copy Markdown

Package awsfirehose - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=awsfirehose

@andrewkroh andrewkroh added the Integration:awsfirehose Amazon Data Firehose label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:awsfirehose Amazon Data Firehose

4 participants