Skip to content

[amazon_security_lake] Remove role creation steps and add notification parsing script parameter - #7887

Merged
bhapas merged 4 commits into
elastic:mainfrom
janvi-elastic:security_lake_remove_role_creation_steps
Sep 22, 2023
Merged

[amazon_security_lake] Remove role creation steps and add notification parsing script parameter#7887
bhapas merged 4 commits into
elastic:mainfrom
janvi-elastic:security_lake_remove_role_creation_steps

Conversation

@janvi-elastic

@janvi-elastic janvi-elastic commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

  • Remove role creation steps
  • Added notification parsing script parameter for collecting data from data subscriber.
  • Update Readme as per requirement for collecting data from SQS.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/amazon_security_lake directory.
  • Run the following command to run tests.

elastic-package test

Screenshots

image
@janvi-elastic
janvi-elastic requested a review from a team as a code owner September 20, 2023 12:00
@elasticmachine

elasticmachine commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-21T10:11:36.502+0000

  • Duration: 14 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 70.588% (12/17) 👎 -29.412
Classes 70.588% (12/17) 👎 -29.412
Methods 56.818% (50/88) 👎 -38.244
Lines 39.96% (3841/9612) 👎 -39.885
Conditionals 100.0% (0/0) 💚
@janvi-elastic janvi-elastic changed the title [amazon_security_lake] Remove role creation steps Sep 21, 2023
@elasticmachine

elasticmachine commented Sep 21, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
bhapas
bhapas reviewed Sep 22, 2023
View reviewed changes

@bhapas bhapas left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tested with an aws instance? Any logs from the test are highly appreciated :-)

Also , Can you please add the screenshot of the changed UI in the PR description.
Comment thread packages/amazon_security_lake/data_stream/event/manifest.yml
Comment thread packages/amazon_security_lake/data_stream/event/manifest.yml
@bhapas bhapas added the Integration:amazon_security_lake Amazon Security Lake label Sep 22, 2023
bhapas
bhapas approved these changes Sep 22, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If tested using an aws instance.
@bhapas
bhapas merged commit 8cef666 into elastic:main Sep 22, 2023
@elasticmachine

elasticmachine commented Sep 22, 2023

Copy link
Copy Markdown

Package amazon_security_lake - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=amazon_security_lake
@andrewkroh

andrewkroh commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

This is the format of the notifications: https://docs.aws.amazon.com/security-lake/latest/userguide/subscriber-data-access.html#sample-notification
@andrewkroh andrewkroh mentioned this pull request Oct 31, 2023
Closed
4 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@janvi-elastic
[amazon_security_lake] Remove role creation steps and add notificatio…
d8733f4 
…n parsing script parameter (elastic#7887)

* Remove role creation steps

* Update Changelog

* Add notification parsing script parameter and update Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:amazon_security_lake Amazon Security Lake

6 participants

@janvi-elastic @elasticmachine @andrewkroh @bhapas @piyush-elastic @jamiehynds