Skip to content

[gcp] Add tags.yml file and upgrade to package spec 3.0 - #7957

Merged
marc-gr merged 3 commits into
elastic:mainfrom
marc-gr:feat/gcp-security-tags
Oct 2, 2023
Merged

[gcp] Add tags.yml file and upgrade to package spec 3.0#7957
marc-gr merged 3 commits into
elastic:mainfrom
marc-gr:feat/gcp-security-tags

Conversation

@marc-gr

@marc-gr marc-gr commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Add tags.yml file so that integration's dashboards and saved searches are tagged with "Security Solution" and displayed in the Security Solution UI.

Upgrade to package spec 3.0

Add missing dashboard filters and remove orphan dashboard references.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

image
@marc-gr marc-gr added enhancement New feature or request Team:Security-External Integrations Integration:gcp Google Cloud Platform labels Sep 25, 2023
@marc-gr
marc-gr force-pushed the feat/gcp-security-tags branch from e5b38bd to 5448358 Compare September 25, 2023 09:03
@marc-gr
marc-gr marked this pull request as ready for review September 25, 2023 09:03
@marc-gr
marc-gr requested review from a team as code owners September 25, 2023 09:03
@elasticmachine

elasticmachine commented Sep 25, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-27T14:10:20.360+0000

  • Duration: 19 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 13.636
Classes 100.0% (6/6) 💚 13.636
Methods 87.826% (101/115) 👍 4.493
Lines 96.013% (1469/1530) 👍 10.992
Conditionals 100.0% (0/0) 💚
@marc-gr
marc-gr marked this pull request as draft September 27, 2023 09:23
@marc-gr
marc-gr force-pushed the feat/gcp-security-tags branch from 5448358 to fabe7c9 Compare September 27, 2023 14:10
@marc-gr
marc-gr marked this pull request as ready for review September 27, 2023 14:10
@marc-gr marc-gr changed the title Add tags.yml file so that integration's dashboards and saved searches are tagged with 'Security Solution' Sep 27, 2023
@marc-gr marc-gr changed the title Add tags.yml file and upgrade to package spec 3.0 Sep 28, 2023
ShourieG
ShourieG approved these changes Sep 28, 2023
View reviewed changes

@ShourieG ShourieG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
kaiyan-sheng
kaiyan-sheng reviewed Sep 28, 2023
View reviewed changes
Comment thread packages/gcp/manifest.yml
@marc-gr
marc-gr requested a review from kaiyan-sheng October 2, 2023 07:17
tommyers-elastic
tommyers-elastic reviewed Oct 2, 2023
View reviewed changes
Comment thread packages/gcp/kibana/dashboard/gcp-1ae960c0-f9f8-11eb-bc38-79936db7c106.json
"name": "controlGroup_70d902f0-3d48-4b91-89ee-2719ab7a1cc5:optionsListDataView",
"type": "index-pattern"
},
{

@tommyers-elastic tommyers-elastic Oct 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i found a few of these dangling references in other packages - do you know what they are/were for?

@marc-gr marc-gr Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, I think they were meaning to target the autogenerated tags? but don't take my word on that
tommyers-elastic
tommyers-elastic approved these changes Oct 2, 2023
View reviewed changes

@tommyers-elastic tommyers-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks !
@marc-gr
marc-gr merged commit d1f2cd4 into elastic:main Oct 2, 2023
@marc-gr
marc-gr deleted the feat/gcp-security-tags branch October 2, 2023 11:40
@elasticmachine

elasticmachine commented Oct 2, 2023

Copy link
Copy Markdown

Package gcp - 2.30.0 containing this change is available at https://epr.elastic.co/search?package=gcp
3 similar comments
@elasticmachine

elasticmachine commented Oct 2, 2023

Copy link
Copy Markdown

Package gcp - 2.30.0 containing this change is available at https://epr.elastic.co/search?package=gcp
@elasticmachine

elasticmachine commented Oct 2, 2023

Copy link
Copy Markdown

Package gcp - 2.30.0 containing this change is available at https://epr.elastic.co/search?package=gcp
@elasticmachine

elasticmachine commented Oct 2, 2023

Copy link
Copy Markdown

Package gcp - 2.30.0 containing this change is available at https://epr.elastic.co/search?package=gcp
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@marc-gr
[gcp] Add tags.yml file and upgrade to package spec 3.0 (elastic#7957)
e84f7e2 
* Add missing dashboard filters and fix orphan dashboard references.

* Upgrade package spec to 3.0.0.

* Add tags.yml file so that integration's dashboards and saved searches are tagged with 'Security Solution' and displayed in the Security Solution UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:gcp Google Cloud Platform

5 participants

@marc-gr @elasticmachine @kaiyan-sheng @ShourieG @tommyers-elastic