Skip to content

[ECS] Cleaning up incorrect invalid ECS field usages at root-level - #7965

Merged
kgeller merged 9 commits into
elastic:mainfrom
kgeller:7808-azurefrontdoor
Sep 26, 2023
Merged

[ECS] Cleaning up incorrect invalid ECS field usages at root-level#7965
kgeller merged 9 commits into
elastic:mainfrom
kgeller:7808-azurefrontdoor

Conversation

@kgeller

@kgeller kgeller commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Removing the unused and incorrect ECS field usages at the root-level for the following packages:

  • azure_frontdoor
  • carbonblack_edr
  • cisco_meraki
  • juniper_srx
  • netflow

Note: this is purely a docs change

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@kgeller kgeller added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:azure_frontdoor Azure Frontdoor labels Sep 25, 2023
@kgeller kgeller self-assigned this Sep 25, 2023
@kgeller kgeller mentioned this pull request Sep 25, 2023
Closed
@kgeller kgeller changed the title [ECS][azure_frontdoor] Cleaning up incorrect invalid ECS field usages at root-level Sep 25, 2023
@elasticmachine

elasticmachine commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T17:50:17.863+0000

  • Duration: 18 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 64
Skipped 0
Total 64

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (21/21) 💚
Classes 100.0% (21/21) 💚
Methods 97.688% (169/173) 👍 9.809
Lines 80.549% (4195/5208) 👎 -14.742
Conditionals 100.0% (0/0) 💚
@kgeller kgeller added the Integration:carbonblack_edr VMware Carbon Black EDR label Sep 25, 2023
@kgeller
kgeller marked this pull request as ready for review September 25, 2023 17:43
@kgeller
kgeller requested a review from a team as a code owner September 25, 2023 17:43
@elasticmachine

elasticmachine commented Sep 25, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
taylor-swanson
taylor-swanson approved these changes Sep 25, 2023
View reviewed changes

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kgeller
kgeller marked this pull request as draft September 25, 2023 18:09
@kgeller kgeller added the Integration:juniper_srx Juniper SRX label Sep 26, 2023
@kgeller kgeller added the Integration:netflow NetFlow Records label Sep 26, 2023
@kgeller
kgeller marked this pull request as ready for review September 26, 2023 18:34
@kgeller
kgeller merged commit 9a14e77 into elastic:main Sep 26, 2023
@kgeller
kgeller deleted the 7808-azurefrontdoor branch September 26, 2023 19:30
@kgeller
kgeller restored the 7808-azurefrontdoor branch September 26, 2023 19:30
@kgeller
kgeller deleted the 7808-azurefrontdoor branch September 26, 2023 19:30
@kgeller
kgeller restored the 7808-azurefrontdoor branch September 26, 2023 19:30
@elasticmachine

elasticmachine commented Sep 26, 2023

Copy link
Copy Markdown

Package azure_frontdoor - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=azure_frontdoor
@elasticmachine

elasticmachine commented Sep 26, 2023

Copy link
Copy Markdown

Package carbonblack_edr - 1.14.1 containing this change is available at https://epr.elastic.co/search?package=carbonblack_edr
@elasticmachine

elasticmachine commented Sep 26, 2023

Copy link
Copy Markdown

Package cisco_meraki - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki
@elasticmachine

elasticmachine commented Sep 26, 2023

Copy link
Copy Markdown

Package juniper_srx - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=juniper_srx
@elasticmachine

elasticmachine commented Sep 26, 2023

Copy link
Copy Markdown

Package netflow - 2.15.1 containing this change is available at https://epr.elastic.co/search?package=netflow
@kgeller kgeller mentioned this pull request Sep 28, 2023
Merged
4 tasks
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@kgeller
[ECS] Cleaning up incorrect invalid ECS field usages at root-level (e…
1a15bfc 
…lastic#7965)

* Cleaning up unused invalid ECS fields at root-level

* changelog

* Cleaning up unused invalid ECS fields at root-level

* Cleaning up unused invalid ECS fields at root-level

* fixing changelog

* Cleaning up unused invalid ECS fields at root-level

* Cleaning up unused invalid ECS fields at root-level

* fixing formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:azure_frontdoor Azure Frontdoor Integration:carbonblack_edr VMware Carbon Black EDR Integration:cisco_meraki Cisco Meraki Integration:juniper_srx Juniper SRX Integration:netflow NetFlow Records

4 participants

@kgeller @elasticmachine @taylor-swanson @andrewkroh