Skip to content

[ECS][panw] Correcting invalid ECS field usages at root-level - #7984

Merged
kgeller merged 2 commits into
elastic:mainfrom
kgeller:7808-panw
Sep 26, 2023
Merged

[ECS][panw] Correcting invalid ECS field usages at root-level#7984
kgeller merged 2 commits into
elastic:mainfrom
kgeller:7808-panw

Conversation

@kgeller

@kgeller kgeller commented Sep 26, 2023

Copy link
Copy Markdown
Member

What does this PR do?

Correcting invalid ECS x509.* field usages at the root-level

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@kgeller kgeller added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels Sep 26, 2023
@kgeller kgeller self-assigned this Sep 26, 2023
@kgeller kgeller mentioned this pull request Sep 26, 2023
Closed
@kgeller kgeller changed the title [ECS][lyve_cloud] Correcting invalid ECS field usages at root-level Sep 26, 2023
@elasticmachine

elasticmachine commented Sep 26, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T16:48:22.197+0000

  • Duration: 19 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 52
Skipped 0
Total 52

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Sep 26, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (15/15) 💚
Classes 100.0% (15/15) 💚
Methods 98.63% (72/73) 👍 10.751
Lines 94.204% (3283/3485) 👎 -1.088
Conditionals 100.0% (0/0) 💚
@kgeller
kgeller marked this pull request as ready for review September 26, 2023 17:08
@kgeller
kgeller requested a review from a team as a code owner September 26, 2023 17:08
@elasticmachine

elasticmachine commented Sep 26, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
taylor-swanson
taylor-swanson approved these changes Sep 26, 2023
View reviewed changes

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kgeller
kgeller merged commit 3e15157 into elastic:main Sep 26, 2023
@kgeller
kgeller deleted the 7808-panw branch September 26, 2023 18:51
@elasticmachine

elasticmachine commented Sep 26, 2023

Copy link
Copy Markdown

Package panw - 3.18.0 containing this change is available at https://epr.elastic.co/search?package=panw
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@kgeller
[ECS][panw] Correcting invalid ECS field usages at root-level (elasti…
c6af734 
…c#7984)

* Correcting invalid ECS field usages at root-level

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall

3 participants

@kgeller @elasticmachine @taylor-swanson