Skip to content

[m365_defender] Fix duplicate event.original field - #8090

Merged
bhapas merged 1 commit into
elastic:mainfrom
bhapas:8034-event-original-issue
Oct 4, 2023
Merged

[m365_defender] Fix duplicate event.original field#8090
bhapas merged 1 commit into
elastic:mainfrom
bhapas:8034-event-original-issue

Conversation

@bhapas

@bhapas bhapas commented Oct 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

Add condition in rename processor from message to event.original to check if the field already exists

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@bhapas bhapas added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:m365_defender Microsoft Defender XDR labels Oct 4, 2023
@bhapas bhapas self-assigned this Oct 4, 2023
@bhapas
bhapas force-pushed the 8034-event-original-issue branch from 97f3d22 to 0a96bd8 Compare October 4, 2023 11:36
@elasticmachine

elasticmachine commented Oct 4, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-04T11:36:42.674+0000

  • Duration: 16 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Oct 4, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 85.556% (77/90) 👍 60.556
Lines 92.621% (5611/6058) 👎 -7.379
Conditionals 100.0% (0/0) 💚
@bhapas
bhapas marked this pull request as ready for review October 4, 2023 11:53
@bhapas
bhapas requested a review from a team as a code owner October 4, 2023 11:53
@elasticmachine

elasticmachine commented Oct 4, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kgeller
kgeller approved these changes Oct 4, 2023
View reviewed changes

@kgeller kgeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@bhapas
bhapas merged commit 6a0f662 into elastic:main Oct 4, 2023
@bhapas
bhapas deleted the 8034-event-original-issue branch October 4, 2023 13:08
@elasticmachine

elasticmachine commented Oct 4, 2023

Copy link
Copy Markdown

Package m365_defender - 2.3.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@bhapas
[m365_defender] Fix duplicate event.original field (elastic#8090)
db9df79 
Add condition in rename processor from message to event.original to check if the field already exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:m365_defender Microsoft Defender XDR

3 participants

@bhapas @elasticmachine @kgeller